added hostname configuration

[radiodario]

• Added hostname configuration key
• altered tests

This is in reponse to #642

[balupton]

Does this output 0.0.0.0 now when null/localhost is set?

[radiodario]

Actually on my tests, it still outputs localhost, which is strange. Also on the current version, even if it's listening on 0.0.0.0 it's saying localhost, which made me think it wouldn't listen on all interfaces, i.e only on loopback. I think it'd be better if it outputs exactly what it is listening on?

[balupton]

Yeah maybe. It could be an aliasing thing in more recent versions of the server stuff. My concern is if we list 0.0.0.0 that could seem strange for people who are expecting localhosg.

Will merge tomorrow :-)

[radiodario]

While I understand your concern, I think calling it localhost when it's
actually listening on 0.0.0.0 would actually be considered misleading. For
me, localhost -> 127.0.0.1, which is very different from actually listening
on all interfaces. :)

On Mon, Dec 16, 2013 at 1:47 PM, Benjamin Arthur Lupton <
notifications@github.com> wrote:

Yeah maybe. It could be an aliasing thing in more recent versions of the
server stuff. My concern is if we list 0.0.0.0 that could seem strange for
people who are expecting localhosg.

Will merge tomorrow :-)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/737#issuecomment-30661245
.

[balupton]

Released to v6.58.2. Changed the localhost display line to check for 127.0.0.1 as re your suggestion.

[radiodario]

Woohoo! Thanks!
On Dec 18, 2013 1:36 AM, "Benjamin Arthur Lupton" notifications@github.com
wrote:

Released to v6.58.2. Changed the localhost display line to check for
127.0.0.1 as re your suggestion.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/737#issuecomment-30809093
.