feat(linter): implement no-nested-ternary (#4067)

Author: kaykdm

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs

@@ -151,6 +151,7 @@ define_categories! {
     "lint/nursery/noIrregularWhitespace": "https://biomejs.dev/linter/rules/no-irregular-whitespace",
     "lint/nursery/noMissingGenericFamilyKeyword": "https://biomejs.dev/linter/rules/no-missing-generic-family-keyword",
     "lint/nursery/noMissingVarFunction": "https://biomejs.dev/linter/rules/no-missing-var-function",
+    "lint/nursery/noNestedTernary": "https://biomejs.dev/linter/rules/no-nested-ternary",
     "lint/nursery/noOctalEscape": "https://biomejs.dev/linter/rules/no-octal-escape",
     "lint/nursery/noProcessEnv": "https://biomejs.dev/linter/rules/no-process-env",
     "lint/nursery/noReactSpecificProps": "https://biomejs.dev/linter/rules/no-react-specific-props",

crates/biome_configuration/src/analyzer/linter/rules.rs

@@ -8,6 +8,7 @@ pub mod no_dynamic_namespace_import_access;
 pub mod no_enum;
 pub mod no_exported_imports;
 pub mod no_irregular_whitespace;
+pub mod no_nested_ternary;
 pub mod no_octal_escape;
 pub mod no_process_env;
 pub mod no_restricted_imports;
@@ -38,6 +39,7 @@ declare_lint_group! {
             self :: no_enum :: NoEnum ,
             self :: no_exported_imports :: NoExportedImports ,
             self :: no_irregular_whitespace :: NoIrregularWhitespace ,
+            self :: no_nested_ternary :: NoNestedTernary ,
             self :: no_octal_escape :: NoOctalEscape ,
             self :: no_process_env :: NoProcessEnv ,
             self :: no_restricted_imports :: NoRestrictedImports ,

crates/biome_diagnostics_categories/src/categories.rs

@@ -0,0 +1,91 @@
+use biome_analyze::{
+    context::RuleContext, declare_lint_rule, Ast, Rule, RuleDiagnostic, RuleSource,
+};
+use biome_console::markup;
+use biome_js_syntax::{AnyJsExpression, JsConditionalExpression};
+use biome_rowan::{AstNode, TextRange};
+
+declare_lint_rule! {
+    /// Disallow nested ternary expressions.
+    ///
+    /// Nesting ternary expressions can make code more difficult to understand.
+    ///
+    /// ## Examples
+    ///
+    /// ### Invalid
+    ///
+    /// ```js,expect_diagnostic
+    /// const thing = foo ? bar : baz === qux ? quxx : foobar;
+    /// ```
+    ///
+    /// ```js,expect_diagnostic
+    /// foo ? baz === qux ? quxx() : foobar() : bar();
+    /// ```
+    ///
+    /// ### Valid
+    ///
+    /// ```js
+    /// const thing = foo ? bar : foobar;
+    /// ```
+    ///
+    /// ```js
+    /// let thing;
+    ///
+    /// if (foo) {
+    ///     thing = bar;
+    /// } else if (baz === qux) {
+    ///     thing = quxx;
+    /// } else {
+    ///     thing = foobar;
+    /// }
+    /// ```
+    ///
+    pub NoNestedTernary {
+        version: "next",
+        name: "noNestedTernary",
+        language: "js",
+        recommended: false,
+        sources: &[RuleSource::Eslint("no-nested-ternary")],
+    }
+}
+
+impl Rule for NoNestedTernary {
+    type Query = Ast<JsConditionalExpression>;
+    type State = TextRange;
+    type Signals = Option<Self::State>;
+    type Options = ();
+
+    fn run(ctx: &RuleContext<Self>) -> Self::Signals {
+        let node = ctx.query();
+        let alternate = node.alternate().ok()?;
+        let consequent = node.consequent().ok()?;
+
+        if let AnyJsExpression::JsConditionalExpression(expr) = consequent {
+            return Some(expr.range());
+        }
+
+        if let AnyJsExpression::JsConditionalExpression(expr) = alternate {
+            return Some(expr.range());
+        }
+
+        None
+    }
+
+    fn diagnostic(_: &RuleContext<Self>, state: &Self::State) -> Option<RuleDiagnostic> {
+        Some(
+            RuleDiagnostic::new(
+                rule_category!(),
+                state,
+                markup! {
+                    "Do not nest ternary expressions."
+                },
+            )
+            .note(markup! {
+                "Nesting ternary expressions can make code more difficult to understand."
+            })
+            .note(markup! {
+                "Convert nested ternary expression into if-else statements or separate the conditions to make the logic easier to understand."
+            }),
+        )
+    }
+}

crates/biome_js_analyze/src/lint/nursery.rs

@@ -0,0 +1,3 @@
+var thing = foo ? bar : baz === qux ? quxx : foobar;
+
+foo ? baz === qux ? quxx() : foobar() : bar();

crates/biome_js_analyze/src/lint/nursery/no_nested_ternary.rs

@@ -0,0 +1,45 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: invalid.js
+---
+# Input
+```jsx
+var thing = foo ? bar : baz === qux ? quxx : foobar;
+
+foo ? baz === qux ? quxx() : foobar() : bar();
+```
+
+# Diagnostics
+```
+invalid.js:1:25 lint/nursery/noNestedTernary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Do not nest ternary expressions.
+  
+  > 1 │ var thing = foo ? bar : baz === qux ? quxx : foobar;
+      │                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
+    2 │ 
+    3 │ foo ? baz === qux ? quxx() : foobar() : bar();
+  
+  i Nesting ternary expressions can make code more difficult to understand.
+  
+  i Convert nested ternary expression into if-else statements or separate the conditions to make the logic easier to understand.
+  
+
+```
+
+```
+invalid.js:3:7 lint/nursery/noNestedTernary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Do not nest ternary expressions.
+  
+    1 │ var thing = foo ? bar : baz === qux ? quxx : foobar;
+    2 │ 
+  > 3 │ foo ? baz === qux ? quxx() : foobar() : bar();
+      │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  
+  i Nesting ternary expressions can make code more difficult to understand.
+  
+  i Convert nested ternary expression into if-else statements or separate the conditions to make the logic easier to understand.
+  
+
+```

crates/biome_js_analyze/src/options.rs

@@ -0,0 +1,12 @@
+/* should not generate diagnostics */
+const thing = foo ? bar : foobar;
+
+let thing;
+
+if (foo) {
+  thing = bar;
+} else if (baz === qux) {
+  thing = quxx;
+} else {
+  thing = foobar;
+}

crates/biome_js_analyze/tests/specs/nursery/noNestedTernary/invalid.js

@@ -0,0 +1,19 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: valid.js
+---
+# Input
+```jsx
+/* should not generate diagnostics */
+const thing = foo ? bar : foobar;
+
+let thing;
+
+if (foo) {
+  thing = bar;
+} else if (baz === qux) {
+  thing = quxx;
+} else {
+  thing = foobar;
+}
+```