fix staticcheck warnings (#598)

Author: apocelipes

SCC-OUTPUT-REPORT.html

@@ -13,13 +13,13 @@
 	<tbody><tr>
 		<th>Go</th>
 		<th>25</th>
-		<th>9417</th>
-		<th>1431</th>
+		<th>9412</th>
+		<th>1430</th>
 		<th>431</th>
-		<th>7555</th>
-		<th>1387</th>
-		<th>253838</th>
-		<th>4066</th>
+		<th>7551</th>
+		<th>1384</th>
+		<th>253787</th>
+		<th>4065</th>
 	</tr><tr>
 		<td>processor/workers_test.go</td>
 		<td></td>
@@ -70,16 +70,6 @@
 		<td>94</td>
 		<td>19592</td>
 		<td>442</td>
-	</tr><tr>
-		<td>cmd/badges/main.go</td>
-		<td></td>
-		<td>436</td>
-		<td>71</td>
-		<td>17</td>
-		<td>348</td>
-		<td>68</td>
-		<td>10910</td>
-		<td>277</td>
 	</tr><tr>
 		<td>main.go</td>
 		<td></td>
@@ -90,6 +80,16 @@
 		<td>8</td>
 		<td>9726</td>
 		<td>271</td>
+	</tr><tr>
+		<td>cmd/badges/main.go</td>
+		<td></td>
+		<td>431</td>
+		<td>70</td>
+		<td>17</td>
+		<td>344</td>
+		<td>65</td>
+		<td>10859</td>
+		<td>276</td>
 	</tr><tr>
 		<td>processor/detector_test.go</td>
 		<td></td>
@@ -274,15 +274,15 @@
 	<tfoot><tr>
 		<th>Total</th>
 		<th>25</th>
-		<th>9417</th>
-		<th>1431</th>
+		<th>9412</th>
+		<th>1430</th>
 		<th>431</th>
-		<th>7555</th>
-		<th>1387</th>
-		<th>253838</th>
-		<th>4066</th>
+		<th>7551</th>
+		<th>1384</th>
+		<th>253787</th>
+		<th>4065</th>
 	</tr>
 	<tr>
-		<th colspan="9">Estimated Cost to Develop (organic) $225,809<br>Estimated Schedule Effort (organic) 7.81 months<br>Estimated People Required (organic) 2.57<br></th>
+		<th colspan="9">Estimated Cost to Develop (organic) $225,683<br>Estimated Schedule Effort (organic) 7.81 months<br>Estimated People Required (organic) 2.57<br></th>
 	</tr></tfoot>
 	</table></body></html>

cmd/badges/main.go

@@ -11,6 +11,7 @@ import (
 	"os/exec"
 	"path/filepath"
 	"regexp"
+	"slices"
 	"strconv"
 	"strings"
 	"sync"
@@ -48,7 +49,7 @@ func main() {
 	http.HandleFunc("/health-check/", func(w http.ResponseWriter, r *http.Request) {
 		locationLogMutex.Lock()
 		for k, v := range locationTracker {
-			_, _ = w.Write([]byte(fmt.Sprintf("%s:%d\n", k, v)))
+			_, _ = fmt.Fprintf(w, "%s:%d\n", k, v)
 		}
 		locationLogMutex.Unlock()
 	})
@@ -115,21 +116,15 @@ func filterBad(loc location) bool {
 		}
 	}
 
-	if count >= 2 {
-		return true
-	}
-
-	return false
+	return count >= 2
 }
 
 func appendLocationLog(log string) {
 	locationLogMutex.Lock()
 	defer locationLogMutex.Unlock()
 
-	for _, l := range locationLog {
-		if l == log {
-			return
-		}
+	if slices.Contains(locationLog, log) {
+		return
 	}
 	locationLog = append(locationLog, log)
 	locationTracker[log] = locationTracker[log] + 1
@@ -400,10 +395,10 @@ func processPath(s string) string {
 		sp = append(sp, cleanString(s))
 	}
 
-	filename := strings.Replace(sp[2], ".com", "", -1)
-	filename = strings.Replace(filename, ".org", "", -1)
+	filename := strings.ReplaceAll(sp[2], ".com", "")
+	filename = strings.ReplaceAll(filename, ".org", "")
 	filename += "." + sp[3]
-	filename += "." + strings.Replace(sp[4], ".git", "", -1) + ".json"
+	filename += "." + strings.ReplaceAll(sp[4], ".git", "") + ".json"
 
 	return filename
 }