fix(ha): handle nil Strict value in HARule and update API response validation

Signed-off-by: Pavel Boldyrev <pavel@bpg.sh>

Author: bpg-dev

fwprovider/cluster/ha/model_harule.go

@@ -59,7 +59,12 @@ func (m *RuleModel) ImportFromAPI(rule harules.HARuleGetResponseData) diag.Diagn
 			m.Nodes = types.MapNull(types.Int64Type)
 		}
 
-		m.Strict = rule.Strict.ToValue()
+		if rule.Strict != nil {
+			m.Strict = rule.Strict.ToValue()
+		} else {
+			m.Strict = types.BoolValue(false)
+		}
+
 		m.Affinity = types.StringNull()
 
 	case RuleTypeResourceAffinity:

fwprovider/cluster/ha/resource_harule.go

@@ -32,6 +32,7 @@ import (
 	"github.com/bpg/terraform-provider-proxmox/fwprovider/config"
 	"github.com/bpg/terraform-provider-proxmox/proxmox/api"
 	harules "github.com/bpg/terraform-provider-proxmox/proxmox/cluster/ha/rules"
+	proxmoxtypes "github.com/bpg/terraform-provider-proxmox/proxmox/types"
 )
 
 var (
@@ -272,7 +273,7 @@ func (r *haruleResource) Create(ctx context.Context, req resource.CreateRequest,
 	case RuleTypeNodeAffinity:
 		nodesStr := r.nodesToString(data.Nodes)
 		createRequest.Nodes = &nodesStr
-		createRequest.Strict.FromValue(data.Strict)
+		createRequest.Strict = proxmoxtypes.CustomBoolPtr(data.Strict.ValueBoolPointer())
 	case RuleTypeResourceAffinity:
 		createRequest.Affinity = data.Affinity.ValueStringPointer()
 	}
@@ -341,7 +342,7 @@ func (r *haruleResource) Update(ctx context.Context, req resource.UpdateRequest,
 	case RuleTypeNodeAffinity:
 		nodesStr := r.nodesToString(data.Nodes)
 		updateRequest.Nodes = &nodesStr
-		updateRequest.Strict.FromValue(data.Strict)
+		updateRequest.Strict = proxmoxtypes.CustomBoolPtr(data.Strict.ValueBoolPointer())
 	case RuleTypeResourceAffinity:
 		updateRequest.Affinity = data.Affinity.ValueStringPointer()
 	}

proxmox/api/client.go

@@ -367,7 +367,8 @@ func validateResponseCode(res *http.Response) error {
 			(res.StatusCode == http.StatusInternalServerError &&
 				(strings.Contains(res.Status, "does not exist") ||
 					strings.Contains(msg, "does not exist") ||
-					strings.Contains(msg, "no such "))) {
+					strings.Contains(msg, "no such resource") ||
+					strings.Contains(msg, "no such ha"))) {
 			return errors.Join(ErrResourceDoesNotExist, httpError)
 		}
 

proxmox/cluster/ha/rules/harules_types.go

@@ -45,7 +45,7 @@ type HARuleNodeAffinityData struct {
 	// A comma-separated list of node names with optional priorities (e.g. node1:2,node2:1).
 	Nodes *string `json:"nodes,omitempty" url:"nodes,omitempty"`
 	// Whether the node affinity rule is strict (resources cannot run on other nodes).
-	Strict types.CustomBool `json:"strict,omitempty" url:"strict,int"`
+	Strict *types.CustomBool `json:"strict,omitempty" url:"strict,omitempty,int"`
 }
 
 // HARuleResourceAffinityData contains fields specific to resource-affinity rules.