Skip to content

Commit 092394e

Browse files
fix(inline-loading): web component update p tag with div parity with react (#21085)
* fix: p tag bringing default margins parity inline loading * chore: make the text color inheriting --------- Co-authored-by: Mahmoud <[email protected]>
1 parent 87ff7d3 commit 092394e

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

packages/styles/scss/components/inline-loading/_inline-loading.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,13 @@ $-loading-gap-small: 110;
2525
.#{$prefix}--inline-loading {
2626
display: flex;
2727
align-items: center;
28+
color: $text-secondary;
2829
inline-size: 100%;
2930
min-block-size: 2rem;
3031
}
3132

3233
.#{$prefix}--inline-loading__text {
3334
@include type-style('label-02');
34-
35-
color: $text-secondary;
3635
}
3736

3837
.#{$prefix}--inline-loading__animation {

packages/web-components/src/components/inline-loading/inline-loading.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ class CDSInlineLoading extends LitElement {
127127
`;
128128
return html`
129129
${statusIconWrapperResult}
130-
<p class="${prefix}--inline-loading__text"><slot></slot></p>
130+
<div class="${prefix}--inline-loading__text"><slot></slot></div>
131131
`;
132132
}
133133

0 commit comments

Comments
 (0)