AllValuesFilter don't allow to ignore empty values

[nepoveda]

I was trying to use AllValuesFilter on my CharFields, but i wanna ignore empty values but changing null_value did not help.

In my oponion It's happening here:

django-filter/django_filters/filters.py

Line 484 in 79b4ea7

self.extra['choices'] = [(o, o) for o in qs]

so for my purpose i change this line to

self.extra['choices'] = [(o, o) for o in qs if o]

For more komplexity I maybe add allow_blank or something similar for this filter and make it optional

[carltongibson]

A None choice doesn’t make much sense. I’d suggest filtering qs rather than adding code here.

[peterhijma]

I don't think the @nepoveda meant that he wants a None choice. He wants to get rid of the None option which is added if you have any empty fields in the database! If you use this filter value (None) => it seems to do nothing.