MDL-84981 core_grades: Update penalty success banners

Author: Fragonite

grade/penalty/manage_exemptions.php

@@ -22,6 +22,7 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
+use core\output\notification;
 use core\url;
 use core_grades\penalty_exemption;
 use core_reportbuilder\system_report_factory;
@@ -118,18 +119,23 @@
         $exemption->delete();
     }
 
-    redirect(new url($url, ['tab' => $exemption->get_itemtype()]),
-        get_string('exemptions:form:successdelete', 'core_grades'));
+    redirect(
+        new url($url, ['tab' => $exemption->get_itemtype()]),
+        get_string('exemptions:form:successdelete', 'core_grades'),
+        0,
+        notification::NOTIFY_SUCCESS
+    );
 }
 
 if ($data = $mform->get_data()) {
     $mform->process($data);
 
-    $message = '';
-    if ($data->create) {
-        $message = get_string('exemptions:form:success', 'core_grades');
-    }
-    redirect(new url($url, ['tab' => $data->type]), $message);
+    redirect(
+        new url($url, ['tab' => $data->type]),
+        $data->create ? get_string('exemptions:form:success', 'core_grades') : '',
+        0,
+        notification::NOTIFY_SUCCESS
+    );
 }
 
 // Start output.

lang/en/grades.php

@@ -228,8 +228,8 @@
 $string['exemptions:form:header'] = 'Add exemption';
 $string['exemptions:form:reason'] = 'Reason';
 $string['exemptions:form:reason_help'] = 'The reason for the exemption.';
-$string['exemptions:form:success'] = 'Exemption updated successfully. Grades affected by the exemption will be recalculated automatically.';
-$string['exemptions:form:successdelete'] = 'Exemption deleted successfully. Grades affected by the exemption will be recalculated automatically.';
+$string['exemptions:form:success'] = 'Exemption updated successfully. Initiated penalty recalculation for affected users. There may be a delay before grades are updated.';
+$string['exemptions:form:successdelete'] = 'Exemption deleted successfully. Initiated penalty recalculation for affected users. There may be a delay before grades are updated.';
 $string['exemptions:form:type'] = 'Type';
 $string['exemptions:form:type:group'] = 'Groups';
 $string['exemptions:form:type:user'] = 'Users';