Skip to content

Commit 072730a

Browse files
authored
Merge branch 'main' into feat/handshake-e2e-attempt
2 parents 5019624 + 6bd1d2f commit 072730a

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

.changeset/happy-icons-float.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

integration/tests/astro/components.test.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,9 @@ testAgainstRunningApps({ withPattern: ['astro.node.withCustomRoles'] })('basic f
488488
await u.page.goToRelative('/server-islands');
489489
// The loading slot for server islands will appear very quickly.
490490
// Wait for next state (default slot) to be ready
491-
await expect(u.page.getByText('Loading')).toBeHidden();
491+
// This is being investigated upstream with the Astro team. The test is commented out for now
492+
// to unblock development and will be revisited once the root cause is resolved.
493+
// await expect(u.page.getByText('Loading')).toBeHidden();
492494
await expect(u.page.getByText('Not an admin')).toBeVisible();
493495

494496
// Sign in as admin user
@@ -504,7 +506,9 @@ testAgainstRunningApps({ withPattern: ['astro.node.withCustomRoles'] })('basic f
504506

505507
// Visit page again
506508
await u.page.goToRelative('/server-islands');
507-
await expect(u.page.getByText('Loading')).toBeHidden();
509+
// This is being investigated upstream with the Astro team. The test is commented out for now
510+
// to unblock development and will be revisited once the root cause is resolved.
511+
// await expect(u.page.getByText('Loading')).toBeHidden();
508512
await expect(u.page.getByText("I'm an admin")).toBeVisible();
509513
});
510514
});

packages/shared/src/react/hooks/useOrganizationList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ const undefinedPaginatedResource = {
7676
export type UseOrganizationListReturn<T extends UseOrganizationListParams> =
7777
| {
7878
/**
79-
* A boolean that indicates whether Clerk has completed initialization and there is an authenicated user. Initially `false`, becomes `true` once Clerk loads with a user
79+
* A boolean that indicates whether Clerk has completed initialization and there is an authenticated user. Initially `false`, becomes `true` once Clerk loads with a user.
8080
*/
8181
isLoaded: false;
8282
/**

0 commit comments

Comments
 (0)