add and fix tests

Author: Thomas Michael

src/main/groovy/com/cloudogu/gitops/features/Jenkins.groovy

@@ -297,6 +297,6 @@ class Jenkins extends Feature {
         ]
     }
     String getActiveNamespaceFromFeature() {
-        return isEnabled() && config.jenkins.internal ? getNamespace() : null
+        return isEnabled() && config?.jenkins?.internal ? getNamespace() : null
     }
 }

src/main/groovy/com/cloudogu/gitops/features/ScmManagerSetup.groovy

@@ -139,6 +139,6 @@ class ScmManagerSetup extends Feature {
     }
 
     String getActiveNamespaceFromFeature() {
-        return isEnabled() && config.scm.scmManager.internal ? getNamespace() : null
+        return isEnabled() && config?.scm?.scmManager?.internal ? getNamespace() : null
     }
 }

src/test/groovy/com/cloudogu/gitops/ApplicationTest.groovy

@@ -1,6 +1,7 @@
 package com.cloudogu.gitops
 
 import com.cloudogu.gitops.config.Config
+import com.cloudogu.gitops.features.git.config.ScmTenantSchema
 import io.micronaut.context.ApplicationContext
 import org.junit.jupiter.api.Test
 
@@ -24,6 +25,9 @@ class ApplicationTest {
     void 'get active namespaces correctly'() {
         config.registry.active = true
         config.jenkins.active = true
+        config.jenkins.internal = true
+        config.scm.scmManager = new ScmTenantSchema.ScmManagerTenantConfig()
+        config.scm.scmManager.internal = true
         config.features.monitoring.active = true
         config.features.argocd.active = true
         config.content.examples = true
@@ -54,6 +58,9 @@ class ApplicationTest {
     void 'get active namespaces correctly in Openshift'() {
         config.registry.active = true
         config.jenkins.active = true
+        config.jenkins.internal = true
+        config.scm.scmManager = new ScmTenantSchema.ScmManagerTenantConfig()
+        config.scm.scmManager.internal = true
         config.features.monitoring.active = true
         config.features.argocd.active = true
         config.content.examples = true
@@ -81,6 +88,38 @@ class ApplicationTest {
         assertThat(config.application.namespaces.getActiveNamespaces()).containsExactlyInAnyOrderElementsOf(namespaceList)
     }
 
+    @Test
+    void 'get active namespaces correctly in Openshift if jenkins and scm are external'() {
+        config.registry.active = true
+        config.jenkins.active = true
+        config.jenkins.internal = false
+        config.scm.scmManager = new ScmTenantSchema.ScmManagerTenantConfig()
+        config.scm.scmManager.internal = false
+        config.features.monitoring.active = true
+        config.features.argocd.active = true
+        config.content.examples = true
+        config.features.ingressNginx.active = true
+        config.application.namePrefix = 'test1-'
+        config.application.openshift = true
+        config.content.namespaces = [
+                '${config.application.namePrefix}example-apps-staging',
+                '${config.application.namePrefix}example-apps-production'
+        ]
+        List<String> namespaceList = new ArrayList<>(Arrays.asList(
+                "test1-argocd",
+                "test1-example-apps-staging",
+                "test1-example-apps-production",
+                "test1-ingress-nginx",
+                "test1-monitoring",
+                "test1-registry",
+        ))
+        def application = ApplicationContext.run()
+                .registerSingleton(config)
+                .getBean(Application)
+        application.setNamespaceListToConfig(config)
+        assertThat(config.application.namespaces.getActiveNamespaces()).containsExactlyInAnyOrderElementsOf(namespaceList)
+    }
+
     @Test
     void 'handles content namespaces without template'() {
         config.content.namespaces = [