Merge pull request #1473 from dominikreisach/datastructures-bounding-boxes

added bounding box computations for Datastructure class, added to_point method for Mesh class

Author: tomvanmele

AUTHORS.md

@@ -42,3 +42,4 @@
 - Joseph Kenny <<[email protected]>> [@jckenny59](https://github.com/jckenny59)
 - Panayiotis Papacharalambous <<[email protected]>> [@papachap](https://github.com/papachap)
 - Oliver Bucklin <<[email protected]>> [@obucklin](https://github.com/obucklin)
+- Dominik Reisach <<[email protected]>> [@dominikreisach](https://github.com/dominikreisach)

CHANGELOG.md

@@ -8,6 +8,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## Unreleased
 
 ### Added
+* Implemented `to_points` method in `compas.datastructures.Mesh`, which before raised a `NotImplementedError`.
+* Implemented `compute_aabb` method in `compas.datastructures.Datastructure`, which before raised a `NotImplementedError`. Made use of the `compas.geometry.bbox.bounding_box` function.
+* Implemented `compute_obb` method in `compas.datastructures.Datastructure`, which before raised a `NotImplementedError`. Made use of the `compas.geometry.bbox_numpy.oriented_bounding_box_numpy` function.
+* Added `vertices_to_points` method in `compas.datastructures.CellNetwork`.
+* Added `to_points` method in `compas.datastructures.VolMesh`.
+* Added test function `test_vertices_to_points`in `test_cell_network.py`.
+* Added test function `test_to_points` in `test_graph.py`.
+* Added test function `test_to_points` in `test_volmesh.py`.
+* Added test functions `test_to_points`, `test_compute_aabb`, and `test_compute_obb` in `test_mesh.py`.
 
 ### Changed
 

src/compas/datastructures/cell_network/cell_network.py

@@ -1171,6 +1171,17 @@ def faces_to_mesh(self, faces, data=False):
                 mesh.add_face(vertices, fkey=fkey)
         return mesh
 
+    def vertices_to_points(self):
+        """Convert the vertices of the cell network to a collection of points.
+
+        Returns
+        -------
+        list[list[float]]
+            The points representing the vertices of the cell network.
+
+        """
+        return [self.vertex_coordinates(vertex) for vertex in self.vertices()]
+
     # --------------------------------------------------------------------------
     # General
     # --------------------------------------------------------------------------

src/compas/datastructures/datastructure.py

@@ -86,7 +86,10 @@ def compute_aabb(self):
         :class:`compas.geometry.Box`
 
         """
-        raise NotImplementedError
+        from compas.geometry import Box
+        from compas.geometry.bbox import bounding_box
+
+        return Box.from_bounding_box(bounding_box(self.to_points()))
 
     def compute_obb(self):
         """Compute the oriented bounding box of the datastructure.
@@ -96,7 +99,10 @@ def compute_obb(self):
         :class:`compas.geometry.Box`
 
         """
-        raise NotImplementedError
+        from compas.geometry import Box
+        from compas.geometry.bbox_numpy import oriented_bounding_box_numpy
+
+        return Box.from_bounding_box(oriented_bounding_box_numpy(self.to_points()))
 
     def transform(self, transformation):
         """Transforms the data structure.

src/compas/datastructures/mesh/mesh.py

@@ -732,7 +732,7 @@ def to_points(self):
             The points representing the vertices of the mesh.
 
         """
-        raise NotImplementedError
+        return [self.vertex_coordinates(vertex) for vertex in self.vertices()]
 
     def to_polygons(self):
         """Convert the mesh to a collection of polygons.

src/compas/datastructures/volmesh/volmesh.py

@@ -559,6 +559,17 @@ def to_vertices_and_cells(self):
             cells.append(faces)
         return vertices, cells
 
+    def to_points(self):
+        """Convert the volmesh to a collection of points.
+
+        Returns
+        -------
+        list[float[float]]
+            The points representing the vertices of the volmesh.
+
+        """
+        return [self.vertex_coordinates(vertex) for vertex in self.vertices()]
+
     def cell_to_mesh(self, cell):
         # type: (int) -> Mesh
         """Construct a mesh object from from a cell of a volmesh.

tests/compas/datastructures/test_cell_network.py

@@ -83,3 +83,14 @@ def test_cell_network_boundary(example_cell_network):
     assert set(ds.faces_without_cell()) == {11}
     assert set(ds.edges_without_face()) == {(15, 13), (14, 12)}
     assert set(ds.nonmanifold_edges()) == {(6, 7), (4, 5), (5, 6), (7, 4)}
+
+
+# ==============================================================================
+# Conversion
+# ==============================================================================
+
+
+def test_vertices_to_points(example_cell_network):
+    ds = example_cell_network
+    points = ds.vertices_to_points()
+    assert len(points) == ds.number_of_vertices()

tests/compas/datastructures/test_graph.py

@@ -276,6 +276,20 @@ def test_graph_to_networkx():
     # assert g2.attributes["val"] == (0, 0, 0), "Graph attributes must be preserved"
 
 
+@pytest.mark.parametrize(
+    "filepath",
+    [
+        compas.get("lines.obj"),
+        compas.get("grid_irregular.obj"),
+    ],
+)
+def test_to_points(filepath):
+    graph = Graph.from_obj(filepath)
+    points = graph.to_points()
+
+    assert len(points) == graph.number_of_nodes(), "Number of points must match number of nodes"
+
+
 # ==============================================================================
 # Methods
 # ==============================================================================

tests/compas/datastructures/test_mesh.py

@@ -340,6 +340,23 @@ def test_to_lines():
     assert len(lines) == mesh.number_of_edges()
 
 
+def test_to_points():
+    # tri
+    mesh = Mesh.from_shape(Polyhedron.from_platonicsolid(4))
+    points = mesh.to_points()
+    assert len(points) == 4
+
+    # quad
+    mesh = Mesh.from_shape(Polyhedron.from_platonicsolid(6))
+    points = mesh.to_points()
+    assert len(points) == 8
+
+    # ngon
+    mesh = Mesh.from_shape(Polyhedron.from_platonicsolid(12))
+    points = mesh.to_points()
+    assert len(points) == 20
+
+
 # --------------------------------------------------------------------------
 # helpers
 # --------------------------------------------------------------------------
@@ -1264,3 +1281,26 @@ def test_face_attributes_includes_all_defaults(box):
     ]
 
     assert box.face_attribute(random_fkey, "attr3") == "value3"
+
+
+# --------------------------------------------------------------------------
+# bounding volumes
+# --------------------------------------------------------------------------
+
+if not compas.IPY:
+
+    def test_compute_aabb():
+        mesh = Mesh.from_obj(compas.get("tubemesh.obj"))
+        aabb = mesh.compute_aabb()
+
+        assert isinstance(aabb, Box)
+        assert len(aabb.points) == 8
+        assert aabb.contains_points(mesh.to_points())
+
+    def test_compute_obb():
+        mesh = Mesh.from_obj(compas.get("tubemesh.obj"))
+        obb = mesh.compute_obb()
+
+        assert isinstance(obb, Box)
+        assert len(obb.points) == 8
+        assert obb.contains_points(mesh.to_points())

tests/compas/datastructures/test_volmesh.py

@@ -346,6 +346,13 @@ def test_cells_where_predicate():
 # Conversion
 # ==============================================================================
 
+
+def test_to_points():
+    vmesh = VolMesh.from_obj(compas.get("boxes.obj"))
+    points = vmesh.to_points()
+    assert len(points) == 27
+
+
 # ==============================================================================
 # Methods
 # ==============================================================================