Skip to content

fix: duplicated names when uploading artifacts #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcusburghardt merged 2 commits into from
Dec 10, 2025
Merged

fix: duplicated names when uploading artifacts #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2136c09
chore: unique name for uploaded scorecard results
marcusburghardt Dec 9, 2025
04752be
chore: rename results file
marcusburghardt Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reusable_scheduled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
scan-args: "${{ inputs.scan-args }}"
fail-on-vuln: true
upload-sarif: true
results-file-name: osv-scanner-scheduled-results-${{ github.workflow }}-${{ github.job }}.sarif
results-file-name: osv-scanner-scheduled-results-${{ github.workflow_sha }}-${{ github.run_number }}.sarif

call_reusable_security:
name: OpenSSF Scorecards
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/reusable_security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,18 @@ jobs:
- name: "Run analysis"
uses: ossf/scorecard-action@4eaacf0543bb3f2c246792bd56e8cdeffafb205a # v2.4.3
with:
results_file: scorecard-results-${{ github.workflow }}-${{ github.job }}.sarif
results_file: scorecard-results-${{ github.workflow_sha }}-${{ github.run_number }}.sarif
results_format: sarif
publish_results: true

- name: "Upload artifact"
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
with:
name: SARIF file
path: scorecard-results-${{ github.workflow }}-${{ github.job }}.sarif
name: Scorecard SARIF file
path: scorecard-results-${{ github.workflow_sha }}-${{ github.run_number }}.sarif
retention-days: 5

- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@fe4161a26a8629af62121b670040955b330f9af2 # v4.31.6
with:
sarif_file: scorecard-results-${{ github.workflow }}-${{ github.job }}.sarif
sarif_file: scorecard-results-${{ github.workflow_sha }}-${{ github.run_number }}.sarif
2 changes: 1 addition & 1 deletion .github/workflows/reusable_vuln_scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ jobs:
scan-args: "${{ inputs.scan-args }}"
fail-on-vuln: true
upload-sarif: true
results-file-name: osv-scanner-pr-results-${{ github.workflow }}-${{ github.job }}.sarif
results-file-name: osv-scanner-pr-results-${{ github.workflow_sha }}-${{ github.run_number }}.sarif
Loading