Commit 43bbbb8
committed
fix(commands): drop double-print of modeline parse failures in root.go
Address review feedback from gemini-code-assist on root.go:255 and
coderabbitai on root.go:257 (same site, two reviewers).
processModelineAndUpdateGlobals printed 'Warning: modeline parsing
failed: <err>' to stderr AND returned errors.Wrapf(err, ...). The
caller threads that wrapped error up to cobra, which surfaces it
through its own stderr writer at command-end. Operators saw the
same underlying error twice — once with a misleading 'Warning:'
prefix, once with the proper command-error rendering.
Drop the explicit Fprintf; let cobra surface the single wrapped
error at the command boundary.
Signed-off-by: Aleksei Sviridkin <f@lex.la>1 parent 1ce809a commit 43bbbb8
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
| |||
251 | 250 | | |
252 | 251 | | |
253 | 252 | | |
254 | | - | |
255 | | - | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
256 | 257 | | |
257 | 258 | | |
258 | 259 | | |
| |||
0 commit comments