Commit 69c4d5d
committed
fix(docs+commands): pass 12 doc-vs-code drift + case-handling rationale
apply-safety-gates-test-plan.md described 'init --update non-tty UX
gap (#174)' as a known limitation in two places (Setup section and
Known limitations section), but #174 is closed by this PR — the
overwrite policy resolves to NonInteractive in non-tty contexts
with a hint-bearing error, and --force accepts all preset-template
diffs non-interactively. Both stale references replaced with the
correct guidance ('pass --force for non-interactive refresh').
manual-test-plan.md's J0-1 footgun example cited 192.168.1.1
(real RFC 1918 private). Replaced with 198.51.100.1 (RFC 5737
TEST-NET-2) to match the documentation-IP convention used
elsewhere in the file.
predicateType (selector.go) lowercases sel.Type before the type
switch, accepting 'SSD' / 'NVMe' that Talos rejects with
'unsupported disk type "SSD"'. The previous godoc claim that
predicateType 'mirrors Talos's v1alpha1 type-selector resolution'
was accurate for the lookup logic but elided the case-handling
divergence. Comment expanded to document the intentional
permissiveness — Phase 1 catches declared-resource mismatches,
not Talos's input-format strictness; tightening would duplicate
Talos's check without operator benefit. No code change.
Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>1 parent d297d00 commit 69c4d5d
3 files changed
Lines changed: 15 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
| 140 | + | |
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | | - | |
207 | 206 | | |
208 | 207 | | |
209 | 208 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
407 | 407 | | |
408 | 408 | | |
409 | 409 | | |
410 | | - | |
| 410 | + | |
411 | 411 | | |
412 | 412 | | |
413 | 413 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
123 | 136 | | |
124 | 137 | | |
125 | 138 | | |
| |||
0 commit comments