fix(lint): resolve all golangci-lint issues

- Remove unused code: readFirstLine, kubernetesFlag, pathAutoCompleteLimit
- Remove entirely unused track.go file
- Replace deprecated io/ioutil with os package
- Fix unchecked error returns for Close() methods
- Fix ineffectual assignments in init.go
- Remove empty branches in age.go

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Author: kvaps

main.go

@@ -3,7 +3,6 @@ package main
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"strings"
@@ -145,7 +144,7 @@ func initConfig() {
 }
 
 func loadConfig(filename string) error {
-	data, err := ioutil.ReadFile(filename)
+	data, err := os.ReadFile(filename)
 	if err != nil {
 		return fmt.Errorf("error reading configuration file: %w", err)
 	}

pkg/age/age.go

@@ -420,15 +420,8 @@ func mergeAndEncryptYAMLValues(plain, encrypted interface{}, identity *age.X2551
 				// Values are the same, keep existing encrypted value (idempotent)
 				return encryptedStr, nil
 			}
-			// If decryption fails or values differ, encrypt new value
-		} else if encryptedStr == plainVal {
-			// Both are plain strings and equal, but we need encrypted version
-			// Encrypt the plain value
-		} else {
-			// Values differ, encrypt new value
 		}
-		
-		// Encrypt the new value
+		// Encrypt the new value (if decryption fails, values differ, or both are plain)
 		return encryptYAMLValues(plain, identity.Recipient())
 
 	default:

pkg/commands/apply.go

@@ -15,11 +15,9 @@
 package commands
 
 import (
-	"bufio"
 	"context"
 	"errors"
 	"fmt"
-	"os"
 	"time"
 
 	"github.com/cozystack/talm/pkg/engine"
@@ -188,33 +186,6 @@ func apply(args []string) error {
 	return nil
 }
 
-// readFirstLine reads and returns the first line of the file specified by the filename.
-// It returns an error if opening or reading the file fails.
-func readFirstLine(filename string) (string, error) {
-	// Open the file
-	file, err := os.Open(filename)
-	if err != nil {
-		return "", fmt.Errorf("error opening file: %v", err)
-	}
-	defer file.Close() // Ensure the file is closed after reading
-
-	// Create a scanner to read the file
-	scanner := bufio.NewScanner(file)
-
-	// Read the first line
-	if scanner.Scan() {
-		return scanner.Text(), nil
-	}
-
-	// Check for errors during scanning
-	if err := scanner.Err(); err != nil {
-		return "", fmt.Errorf("error reading file: %v", err)
-	}
-
-	// If no lines in the file, return an empty string
-	return "", nil
-}
-
 func init() {
 	applyCmd.Flags().BoolVarP(&applyCmdFlags.insecure, "insecure", "i", false, "apply using the insecure (encrypted with no auth) maintenance service")
 	applyCmd.Flags().StringSliceVarP(&applyCmdFlags.configFiles, "file", "f", nil, "specify config files or patches in a YAML file (can specify multiple)")

pkg/commands/init.go

@@ -324,10 +324,8 @@ var initCmd = &cobra.Command{
 
 		// If encrypted file exists, decrypt it (don't require key - will generate if needed)
 		if encryptedTalosconfigFileExists && !talosconfigFileExists {
-			_, err := handleTalosconfigEncryption(false)
-			if err != nil {
-				// If decryption fails (e.g., no key), continue to generate
-			}
+			// If decryption fails (e.g., no key), continue to generate
+			_, _ = handleTalosconfigEncryption(false)
 			talosconfigFileExists = fileExists(talosconfigFile)
 		}
 
@@ -347,7 +345,6 @@ var initCmd = &cobra.Command{
 			if err = writeToDestination(data, talosconfigFile, 0o600); err != nil {
 				return err
 			}
-			talosconfigFileExists = true
 		}
 
 		// Encrypt talosconfig if needed
@@ -385,7 +382,6 @@ var initCmd = &cobra.Command{
 				if err != nil {
 					return fmt.Errorf("failed to generate key: %w", err)
 				}
-				keyFileExists = true // Update flag after creation
 				keyWasCreated = keyCreated
 			}
 
@@ -417,7 +413,7 @@ var initCmd = &cobra.Command{
 			if chartName == initCmdFlags.preset {
 				file := filepath.Join(Config.RootDir, filepath.Join(parts[1:]...))
 				if parts[len(parts)-1] == "Chart.yaml" {
-					writeToDestination([]byte(fmt.Sprintf(content, clusterName, Config.InitOptions.Version)), file, 0o644)
+					err = writeToDestination([]byte(fmt.Sprintf(content, clusterName, Config.InitOptions.Version)), file, 0o644)
 				} else {
 					err = writeToDestination([]byte(content), file, 0o644)
 				}
@@ -429,7 +425,7 @@ var initCmd = &cobra.Command{
 			if chartName == "talm" {
 				file := filepath.Join(Config.RootDir, filepath.Join("charts", path))
 				if parts[len(parts)-1] == "Chart.yaml" {
-					writeToDestination([]byte(fmt.Sprintf(content, "talm", Config.InitOptions.Version)), file, 0o644)
+					err = writeToDestination([]byte(fmt.Sprintf(content, "talm", Config.InitOptions.Version)), file, 0o644)
 				} else {
 					err = writeToDestination([]byte(content), file, 0o644)
 				}
@@ -856,7 +852,6 @@ func handleTalosconfigEncryption(requireKeyForDecrypt bool) (bool, error) {
 			if keyCreated {
 				fmt.Fprintf(os.Stderr, "Generated new encryption key: talm.key\n")
 			}
-			keyFileExists = true
 		}
 
 		// Encrypt talosconfig

pkg/commands/root.go

@@ -30,8 +30,6 @@ import (
 	"github.com/siderolabs/talos/pkg/machinery/client"
 )
 
-var kubernetesFlag bool
-
 // GlobalArgs is the common arguments for the root command.
 var GlobalArgs global.Args
 
@@ -72,8 +70,6 @@ var Config struct {
 	}
 }
 
-const pathAutoCompleteLimit = 500
-
 // WithClientNoNodes wraps common code to initialize Talos client and provide cancellable context.
 //
 // WithClientNoNodes doesn't set any node information on the request context.

pkg/commands/track.go

@@ -544,7 +544,7 @@ func applyPatchesAndRenderConfig(ctx context.Context, opts Options, configPatche
 	if err := encoder.Encode(&targetNode); err != nil {
 		return nil, err
 	}
-	encoder.Close()
+	_ = encoder.Close()
 
 	// Append extra documents (like UserVolumeConfig) that are not part of Talos config
 	for _, extraDoc := range extraDocs {

pkg/engine/engine.go

@@ -56,7 +56,7 @@ func ReadAndParseModeline(filePath string) (*Config, error) {
 	if err != nil {
 		return nil, fmt.Errorf("error opening config file: %v", err)
 	}
-	defer file.Close()
+	defer func() { _ = file.Close() }()
 
 	scanner := bufio.NewScanner(file)
 	if scanner.Scan() {

pkg/modeline/modeline.go

@@ -77,7 +77,7 @@ func DiffYAMLs(original, modified []byte) ([]byte, error) {
 	if err := encoder.Encode(diff); err != nil {
 		return nil, err
 	}
-	encoder.Close()
+	_ = encoder.Close()
 
 	return buffer.Bytes(), nil
 }