test (e2e) : add step for setting persistent-volume-size config option (#4186)

Add step for `persistent-volume-size` config option in story_microshift.feature

Signed-off-by: Rohan Kumar <[email protected]>

Author: rohanKanojia

test/e2e/features/config.feature

@@ -17,30 +17,30 @@ Feature: Test configuration settings
         # always return to default values
         @darwin
         Examples: Config settings on Mac
-            | property           | value1    | value2            |
-            | cpus               | 5         | 3                 |
-            | memory             | 10753     | 4096              |
-            | nameserver         | 120.0.0.1 | 999.999.999.999   |
-            | pull-secret-file   | /etc      | /nonexistent-file |
-            | developer-password | secret1   |                   |
+            | property               | value1    | value2            |
+            | cpus                   | 5         | 3                 |
+            | memory                 | 10753     | 4096              |
+            | nameserver             | 120.0.0.1 | 999.999.999.999   |
+            | pull-secret-file       | /etc      | /nonexistent-file |
+            | persistent-volume-size | 20        | 5                 |
 
         @linux
         Examples: Config settings on Linux
-            | property           | value1    | value2            |
-            | cpus               | 5         | 3                 |
-            | memory             | 10753     | 4096              |
-            | nameserver         | 120.0.0.1 | 999.999.999.999   |
-            | pull-secret-file   | /etc      | /nonexistent-file |
-            | developer-password | secret1   |                   |
+            | property               | value1    | value2            |
+            | cpus                   | 5         | 3                 |
+            | memory                 | 10753     | 4096              |
+            | nameserver             | 120.0.0.1 | 999.999.999.999   |
+            | pull-secret-file       | /etc      | /nonexistent-file |
+            | persistent-volume-size | 20        | 5                 |
 
         @windows
         Examples: Config settings on Windows
-            | property           | value1    | value2            |
-            | cpus               | 5         | 3                 |
-            | memory             | 10753     | 4096              |
-            | nameserver         | 120.0.0.1 | 999.999.999.999   |
-            | pull-secret-file   | /Users    | /nonexistent-file |
-            | developer-password | secret1   |                   |
+            | property               | value1    | value2            |
+            | cpus                   | 5         | 3                 |
+            | memory                 | 10753     | 4096              |
+            | nameserver             | 120.0.0.1 | 999.999.999.999   |
+            | pull-secret-file       | /Users    | /nonexistent-file |
+            | persistent-volume-size | 20        | 5                 |
 
     @linux @darwin @windows
     Scenario: CRC config checks (bundle version)

test/e2e/features/story_microshift.feature

@@ -3,12 +3,17 @@ Feature: Microshift test stories
 
 	Background:
 		Given setting config property "preset" to value "microshift" succeeds
+		And setting config property "disk-size" to value "41" succeeds
+		And setting config property "persistent-volume-size" to value "20" succeeds
 		And ensuring network mode user
 		And executing single crc setup command succeeds
 		And starting CRC with default bundle succeeds
 		And ensuring oc command is available
 		And ensuring microshift cluster is fully operational
-		
+		And executing "crc status" succeeds
+		And stdout should contain "Persistent Volume Usage:"
+		And persistent volume of size "20"GB exists
+
 	# End-to-end health check
 
 	@microshift @testdata @linux @windows @darwin @cleanup

test/e2e/testsuite/testsuite.go

@@ -6,15 +6,19 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
+	"math"
 	"net/http"
 	"os"
 	"os/user"
 	"path/filepath"
 	"runtime"
+	"slices"
+	"strconv"
 	"strings"
 	"time"
 
 	"github.com/containers/common/pkg/strongunits"
+	"github.com/crc-org/crc/v2/pkg/crc/ssh"
 	"github.com/spf13/cast"
 
 	"github.com/crc-org/crc/v2/pkg/crc/constants"
@@ -562,6 +566,8 @@ func InitializeScenario(s *godog.ScenarioContext) {
 		EnsureCrcVersionIsCorrect)
 	s.Step(`^ensure service "(.*)" is accessible via NodePort with response body "(.*)"$`,
 		EnsureApplicationIsAccessibleViaNodePort)
+	s.Step(`^persistent volume of size "([^"]*)"GB exists$`,
+		EnsureVMPartitionSizeCorrect)
 
 	s.After(func(ctx context.Context, _ *godog.Scenario, err error) (context.Context, error) {
 
@@ -1215,3 +1221,79 @@ func EnsureMicroshiftClusterIsOperational() error {
 
 	return nil
 }
+
+func EnsureVMPartitionSizeCorrect(expectedPVSizeStr string) error {
+	expectedPVSize, err := strconv.Atoi(expectedPVSizeStr)
+	if err != nil {
+		return fmt.Errorf("invalid expected persistent volume size provided in test input")
+	}
+	err = util.ExecuteCommand("crc ip")
+	if err != nil {
+		return fmt.Errorf("error in determining crc vm's ip address: %v", err)
+	}
+	crcIP := util.GetLastCommandOutput("stdout")
+	runner, err := ssh.CreateRunner(crcIP, 2222, filepath.Join(util.CRCHome, "machines", "crc", "id_ed25519"))
+	if err != nil {
+		return fmt.Errorf("error creating ssh runner: %v", err)
+	}
+	out, _, err := runner.Run("lsblk -oTYPE,SIZE -n")
+	if err != nil {
+		return fmt.Errorf("error in executing command in crc vm: %v", err)
+	}
+
+	actualPVSize, err := deserializeListBlockDeviceCommandOutputToExtractPVSize(out)
+	if err != nil {
+		return err
+	}
+	if actualPVSize != expectedPVSize {
+		return fmt.Errorf("expecting persistent volume size to be %d, got %d", expectedPVSize, actualPVSize)
+	}
+	return nil
+}
+
+func deserializeListBlockDeviceCommandOutputToExtractPVSize(lsblkOutput string) (int, error) {
+	type BlockDevice struct {
+		DeviceType string
+		Size       string
+	}
+	blockDevices := make([]BlockDevice, 0)
+	lines := strings.Split(lsblkOutput, "\n")
+
+	for _, line := range lines {
+		fields := strings.Fields(line)
+		if len(fields) < 2 {
+			continue
+		}
+
+		blockDevices = append(blockDevices, BlockDevice{
+			DeviceType: fields[0],
+			Size:       fields[1],
+		})
+	}
+
+	var lvmSize int
+	lvmBlockDeviceIndex := slices.IndexFunc(blockDevices, func(b BlockDevice) bool {
+		return b.DeviceType == "lvm"
+	})
+	if lvmBlockDeviceIndex == -1 {
+		return -1, fmt.Errorf("expecting lsblk output to contain a lvm device, got no device with type lvm")
+	}
+	_, err := fmt.Sscanf(blockDevices[lvmBlockDeviceIndex].Size, "%dG", &lvmSize)
+	if err != nil {
+		return -1, fmt.Errorf("error in scanning lvm device size: %v", err)
+	}
+
+	var diskSize = math.MinInt64
+	for _, blockDevice := range blockDevices {
+		if blockDevice.DeviceType == "disk" {
+			diskSizeValue, err := strconv.ParseFloat(strings.TrimSuffix(blockDevice.Size, "G"), 64)
+			if err != nil {
+				return -1, fmt.Errorf("error in parsing disk size: %v", err)
+			}
+			if int(diskSizeValue) > diskSize {
+				diskSize = int(diskSizeValue)
+			}
+		}
+	}
+	return diskSize - (lvmSize + 1), nil
+}