Closed
Description
A new .names parameter was added to dm_from_con() in 1.0.6 (#1790).
This is used in dm:::get_src_tbl_names() to construct names to be used in the data model.
However, in dm_from_con(), we then completely ignore those names and use the table name instead:
#! We work hard to set names here...
if (is_null(table_names)) {
src_tbl_names <- get_src_tbl_names(src, ..., names = .names)
} else {
src_tbl_names <- table_names
}
#! ... and then override them anyway!
nms <- purrr::map_chr(src_tbl_names, ~ .x@name[["table"]])
tbls <-
set_names(src_tbl_names, nms) %>%
quote_ids(con) %>%
map(possibly(tbl, NULL), src = src)Metadata
Metadata
Assignees
Labels
No labels