potential fix for race condidion affecting ATs (besu-eth#9929)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>

Author: macfarla

acceptance-tests/dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/node/BesuNode.java

@@ -365,8 +365,14 @@ private String getDiscoveryPort() {
 
   public Optional<String> jsonRpcBaseUrl() {
     if (isJsonRpcEnabled()) {
-      return Optional.of(
-          HTTP + jsonRpcConfiguration.getHost() + ":" + portsProperties.getProperty(JSON_RPC));
+      final String port = portsProperties.getProperty(JSON_RPC);
+      if (port == null) {
+        throw new IllegalStateException(
+            "JSON-RPC port not available for node "
+                + name
+                + ". Node may have failed to start or ports file was not written.");
+      }
+      return Optional.of(HTTP + jsonRpcConfiguration.getHost() + ":" + port);
     } else {
       return Optional.empty();
     }

acceptance-tests/dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/node/ProcessBesuNodeRunner.java

@@ -461,7 +461,13 @@ private void waitForFileOrExit(final BesuNode node, final String fileName) {
     Awaitility.waitAtMost(60, TimeUnit.SECONDS)
         .until(
             () -> {
-              if (!besuProcesses.get(node.getName()).isAlive()) {
+              final Process process = besuProcesses.get(node.getName());
+              if (!process.isAlive()) {
+                LOG.warn(
+                    "Besu process for node {} exited with code {} before writing {}",
+                    node.getName(),
+                    process.exitValue(),
+                    fileName);
                 return true;
               }