Merge pull request #27 from danmurphy1217/add-advanced-property-support

Add Advanced Property Type Support: Relations

Author: danmurphy1217

.travis.yml

@@ -1,5 +1,4 @@
 language: ruby
-cache: bundler
 dist: bionic
 rvm:
 # using .filter, so must be >= 2.6... will update to be .select later...

lib/notion_api/notion_types/collection_view_blocks.rb

@@ -273,7 +273,7 @@ def create_singleton_methods_and_instance_variables(row, row_data)
             space_id: space_id,
           }
 
-          update_property_value_hash = Utils::CollectionViewComponents.update_property_value(@id, column_hash.key(parsed_method), new_value)
+          update_property_value_hash = Utils::CollectionViewComponents.update_property_value(@id, column_hash.key(parsed_method), new_value, schema[column_hash.key(parsed_method)]["type"])
 
           operations = [
             update_property_value_hash,

lib/notion_api/utils.rb

@@ -224,14 +224,14 @@ def self.row_location_add(last_row_id, block_id, view_id)
         "table": "collection_view",
         "id": view_id,
         "path": [
-            "page_sort"
+          "page_sort",
         ],
         "command": "listAfter",
         "args": {
-            "after": last_row_id,
-            "id": block_id
-        }
-    }
+          "after": last_row_id,
+          "id": block_id,
+        },
+      }
     end
 
     def self.block_location_remove(block_parent_id, block_id)
@@ -459,6 +459,7 @@ def self.insert_data(block_id, column, value, mapping)
       datetime_mappings = ["date"]
       media_mappings = ["file"]
       person_mappings = ["person"]
+      page_mappings = ["relation"]
 
       table = "block"
       path = [
@@ -475,10 +476,12 @@ def self.insert_data(block_id, column, value, mapping)
         args = [["‣", [["d", { "type": "date", "start_date": value }]]]]
       elsif person_mappings.include?(mapping)
         args = [["‣",
-          [["u", value]]
-        ]]
-        else 
-          raise SchemaTypeError, "Invalid property type: #{mapping}"
+                 [["u", value]]]]
+      elsif page_mappings.include?(mapping)
+        args = [["‣",
+                 [["p", value]]]]
+      else
+        raise SchemaTypeError, "Invalid property type: #{mapping}"
       end
 
       {
@@ -499,10 +502,10 @@ def self.add_new_option(column, value, collection_id)
 
       args = {
         "value": {
-            "id": SecureRandom.hex(16),
-            "value": value,
-            "color": random_color
-        }
+          "id": SecureRandom.hex(16),
+          "value": value,
+          "color": random_color,
+        },
       }
 
       {
@@ -593,10 +596,10 @@ def self.add_collection_property(collection_id, args)
             "width" => 200,
           },
           {
-                  "property" => "phone",
-                  "visible" => true,
-                  "width" => 200,
-                },
+            "property" => "phone",
+            "visible" => true,
+            "width" => 200,
+          },
           {
             "property" => "unicode_version",
             "visible" => true,
@@ -613,20 +616,28 @@ def self.add_collection_property(collection_id, args)
       }
     end
 
-    def self.update_property_value(page_id, column_name, new_value)
+    def self.update_property_value(page_id, column_name, new_value, column_type)
       # ! update the specified column_name to new_value
       # ! page_id -> the ID of the page: ``str``
       # ! column_name -> the name of the column ["property"] to update: ``str``
       # ! new_value -> the new value to assign to that column ["property"]: ``str``
+      # ! column_type -> the type of the property: ``str``
       table = "block"
       path = [
         "properties",
         column_name,
       ]
       command = "set"
-      args = [[
-        new_value,
-      ]]
+
+      if column_type == "relation"
+        args = [["‣", [[
+          "p", new_value,
+        ]]]]
+      else
+        args = [[
+          new_value,
+        ]]
+      end
 
       {
         id: page_id,
@@ -639,7 +650,7 @@ def self.update_property_value(page_id, column_name, new_value)
   end
 
   class SchemaTypeError < StandardError
-    def initialize(msg="Custom exception that is raised when an invalid property type is passed as a mapping.", exception_type="schema_type")
+    def initialize(msg = "Custom exception that is raised when an invalid property type is passed as a mapping.", exception_type = "schema_type")
       @exception_type = exception_type
       super(msg)
     end
@@ -665,4 +676,4 @@ def build_payload(operations, request_ids)
     }
     payload
   end
-end
+end

notion.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
     spec.add_runtime_dependency('httparty', '~> 0.17')
     spec.add_runtime_dependency('json', '~> 2.2')
 
-    spec.add_development_dependency("bundler", "~> 2.1.0")
+    spec.add_development_dependency("bundler")
     spec.add_development_dependency("rake", "~> 13.0.0")
     spec.add_development_dependency("rspec", "~> 3.9.0")
     spec.add_development_dependency("rubocop", "~> 1.4.0")