Use Dart 3.7.0, reformat. (#762)

Author: davidmorgan

.github/workflows/dart.yml

@@ -40,23 +40,23 @@ jobs:
       - name: mono_repo self validate
         run: dart pub global run mono_repo generate --validate
   job_002:
-    name: "analyze_format; linux; Dart 3.6.0; PKG: source_gen; `dart analyze`"
+    name: "analyze_format; linux; Dart 3.7.0; PKG: source_gen; `dart analyze`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:source_gen;commands:analyze_1"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.7.0;packages:source_gen;commands:analyze_1"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:source_gen
-            os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.7.0;packages:source_gen
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.7.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
         with:
-          sdk: "3.6.0"
+          sdk: "3.7.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -143,23 +143,23 @@ jobs:
         if: "always() && steps.source_gen_pub_upgrade.conclusion == 'success'"
         working-directory: source_gen
   job_004:
-    name: "unit_test; linux; Dart 3.6.0; PKG: example_usage; `dart test --run-skipped`"
+    name: "unit_test; linux; Dart 3.7.0; PKG: example_usage; `dart test --run-skipped`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:example_usage;commands:test_0"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.7.0;packages:example_usage;commands:test_0"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:example_usage
-            os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.7.0;packages:example_usage
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.7.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
         with:
-          sdk: "3.6.0"
+          sdk: "3.7.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -177,23 +177,23 @@ jobs:
       - job_002
       - job_003
   job_005:
-    name: "unit_test; linux; Dart 3.6.0; PKG: source_gen; `dart test`"
+    name: "unit_test; linux; Dart 3.7.0; PKG: source_gen; `dart test`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:source_gen;commands:test_1"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:3.7.0;packages:source_gen;commands:test_1"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0;packages:source_gen
-            os:ubuntu-latest;pub-cache-hosted;sdk:3.6.0
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.7.0;packages:source_gen
+            os:ubuntu-latest;pub-cache-hosted;sdk:3.7.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
         with:
-          sdk: "3.6.0"
+          sdk: "3.7.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -279,13 +279,13 @@ jobs:
       - job_002
       - job_003
   job_008:
-    name: "unit_test; windows; Dart 3.6.0; PKG: source_gen; `dart test`"
+    name: "unit_test; windows; Dart 3.7.0; PKG: source_gen; `dart test`"
     runs-on: windows-latest
     steps:
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
         with:
-          sdk: "3.6.0"
+          sdk: "3.7.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683

_test_annotations/pubspec.yaml

@@ -3,7 +3,7 @@ publish_to: none
 resolution: workspace
 
 environment:
-  sdk: ^3.6.0
+  sdk: ^3.7.0
 
 dev_dependencies:
   dart_flutter_team_lints: ^3.1.0

analysis_options.yaml

@@ -29,7 +29,6 @@ linter:
     - prefer_const_declarations
     - prefer_expression_function_bodies
     - prefer_final_locals
-    - require_trailing_commas
     - sort_child_properties_last
     - unnecessary_await_in_return
     - use_full_hex_values_for_flutter_colors

example/lib/builder.dart

@@ -21,9 +21,9 @@ import 'src/property_product_generator.dart';
 import 'src/property_sum_generator.dart';
 
 Builder metadataLibraryBuilder(BuilderOptions options) => LibraryBuilder(
-      MemberCountLibraryGenerator(),
-      generatedExtension: '.info.dart',
-    );
+  MemberCountLibraryGenerator(),
+  generatedExtension: '.info.dart',
+);
 
 Builder productBuilder(BuilderOptions options) =>
     SharedPartBuilder([PropertyProductGenerator()], 'product');

example/lib/src/property_product_generator.dart

@@ -10,9 +10,9 @@ import 'utils.dart';
 class PropertyProductGenerator extends Generator {
   @override
   String generate(LibraryReader library, BuildStep buildStep) {
-    final productNames = topLevelNumVariables(library)
-        .map((element) => element.name)
-        .join(' * ');
+    final productNames = topLevelNumVariables(
+      library,
+    ).map((element) => element.name).join(' * ');
 
     return '''
 num allProduct() => $productNames;

example/lib/src/property_sum_generator.dart

@@ -10,9 +10,9 @@ import 'utils.dart';
 class PropertySumGenerator extends Generator {
   @override
   String generate(LibraryReader library, BuildStep buildStep) {
-    final sumNames = topLevelNumVariables(library)
-        .map((element) => element.name)
-        .join(' + ');
+    final sumNames = topLevelNumVariables(
+      library,
+    ).map((element) => element.name).join(' + ');
 
     return '''
 num allSum() => $sumNames;

example/lib/src/utils.dart

@@ -9,8 +9,8 @@ import 'package:source_gen/source_gen.dart';
 /// have a type of [num].
 Iterable<TopLevelVariableElement> topLevelNumVariables(LibraryReader reader) =>
     reader.allElements.whereType<TopLevelVariableElement>().where(
-          (element) =>
-              element.type.isDartCoreNum ||
-              element.type.isDartCoreInt ||
-              element.type.isDartCoreDouble,
-        );
+      (element) =>
+          element.type.isDartCoreNum ||
+          element.type.isDartCoreInt ||
+          element.type.isDartCoreDouble,
+    );

example/pubspec.yaml

@@ -3,7 +3,7 @@ publish_to: none
 resolution: workspace
 
 environment:
-  sdk: ^3.6.0
+  sdk: ^3.7.0
 
 dependencies:
   analyzer: '>=6.9.0 <8.0.0'

example_usage/pubspec.yaml

@@ -3,7 +3,7 @@ publish_to: none
 resolution: workspace
 
 environment:
-  sdk: ^3.6.0
+  sdk: ^3.7.0
 
 dependencies:
   source_gen_example:

source_gen/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.0.1-wip
+
+- Require Dart 3.7.0
+
 ## 2.0.0
 
 - **Breaking Change**: Change `formatOutput` function to accept a language

source_gen/lib/builder.dart

@@ -33,8 +33,10 @@ Builder combiningBuilder([BuilderOptions options = BuilderOptions.empty]) {
     optionsMap.remove('ignore_for_file') as List? ?? <String>[],
   );
   final preamble = optionsMap.remove('preamble') as String? ?? '';
-  final buildExtensions =
-      validatedBuildExtensionsFrom(optionsMap, _defaultExtensions);
+  final buildExtensions = validatedBuildExtensionsFrom(
+    optionsMap,
+    _defaultExtensions,
+  );
 
   final builder = CombiningBuilder(
     includePartName: includePartName,
@@ -75,18 +77,19 @@ class CombiningBuilder implements Builder {
     Set<String>? ignoreForFile,
     String? preamble,
     this.buildExtensions = _defaultExtensions,
-  })  : _includePartName = includePartName ?? false,
-        _ignoreForFile = ignoreForFile ?? const <String>{},
-        _preamble = preamble ?? '';
+  }) : _includePartName = includePartName ?? false,
+       _ignoreForFile = ignoreForFile ?? const <String>{},
+       _preamble = preamble ?? '';
 
   @override
   Future<void> build(BuildStep buildStep) async {
     // Pattern used for `findAssets`, which must be glob-compatible
     final assetPath = buildStep.inputId.path;
     final pattern = '${p.withoutExtension(Glob.quote(assetPath))}.*$_partFiles';
 
-    final inputBaseName =
-        p.basenameWithoutExtension(buildStep.inputId.pathSegments.last);
+    final inputBaseName = p.basenameWithoutExtension(
+      buildStep.inputId.pathSegments.last,
+    );
 
     // Pattern used to ensure items are only considered if they match
     // [file name without extension].[valid part id].[part file extension]
@@ -101,11 +104,12 @@ class CombiningBuilder implements Builder {
       ].join(),
     );
 
-    final assetIds = await buildStep
-        .findAssets(Glob(pattern))
-        .where((id) => restrictedPattern.hasMatch(id.pathSegments.last))
-        .toList()
-      ..sort();
+    final assetIds =
+        await buildStep
+              .findAssets(Glob(pattern))
+              .where((id) => restrictedPattern.hasMatch(id.pathSegments.last))
+              .toList()
+          ..sort();
 
     final assets = await Stream.fromIterable(assetIds)
         .asyncMap((id) async {
@@ -124,8 +128,9 @@ class CombiningBuilder implements Builder {
     final partOfUri = uriOfPartial(inputLibrary, buildStep.inputId, outputId);
 
     // Ensure that the input has a correct `part` statement.
-    final libraryUnit =
-        await buildStep.resolver.compilationUnitFor(buildStep.inputId);
+    final libraryUnit = await buildStep.resolver.compilationUnitFor(
+      buildStep.inputId,
+    );
     final part = computePartUrl(buildStep.inputId, outputId);
     if (!hasExpectedPartDirective(libraryUnit, part)) {
       log.warning(
@@ -135,9 +140,10 @@ class CombiningBuilder implements Builder {
       return;
     }
 
-    final ignoreForFile = _ignoreForFile.isEmpty
-        ? ''
-        : '\n// ignore_for_file: ${_ignoreForFile.join(', ')}\n';
+    final ignoreForFile =
+        _ignoreForFile.isEmpty
+            ? ''
+            : '\n// ignore_for_file: ${_ignoreForFile.join(', ')}\n';
 
     final preamble = _preamble.isEmpty ? '' : '\n$_preamble\n';
 

source_gen/lib/src/builder.dart

@@ -57,16 +57,15 @@ class _Builder extends Builder {
     bool? writeDescriptions,
     this.allowSyntaxErrors = false,
     BuilderOptions? options,
-  })  : _generatedExtension = generatedExtension,
-        buildExtensions = validatedBuildExtensionsFrom(
-            options != null ? Map.of(options.config) : null, {
-          '.dart': [
-            generatedExtension,
-            ...additionalOutputExtensions,
-          ],
-        }),
-        _writeDescriptions = writeDescriptions ?? true,
-        _header = (header ?? defaultFileHeader).trim() {
+  }) : _generatedExtension = generatedExtension,
+       buildExtensions = validatedBuildExtensionsFrom(
+         options != null ? Map.of(options.config) : null,
+         {
+           '.dart': [generatedExtension, ...additionalOutputExtensions],
+         },
+       ),
+       _writeDescriptions = writeDescriptions ?? true,
+       _header = (header ?? defaultFileHeader).trim() {
     if (_generatedExtension.isEmpty || !_generatedExtension.startsWith('.')) {
       throw ArgumentError.value(
         _generatedExtension,
@@ -102,8 +101,10 @@ class _Builder extends Builder {
       return;
     }
 
-    final lib = await buildStep.resolver
-        .libraryFor(buildStep.inputId, allowSyntaxErrors: allowSyntaxErrors);
+    final lib = await buildStep.resolver.libraryFor(
+      buildStep.inputId,
+      allowSyntaxErrors: allowSyntaxErrors,
+    );
     await _generateForLibrary(lib, buildStep);
   }
 
@@ -138,10 +139,13 @@ class _Builder extends Builder {
           ..writeln('part of \'$partOfUri\';');
         final part = computePartUrl(buildStep.inputId, outputId);
 
-        final libraryUnit =
-            await buildStep.resolver.compilationUnitFor(buildStep.inputId);
-        final hasLibraryPartDirectiveWithOutputUri =
-            hasExpectedPartDirective(libraryUnit, part);
+        final libraryUnit = await buildStep.resolver.compilationUnitFor(
+          buildStep.inputId,
+        );
+        final hasLibraryPartDirectiveWithOutputUri = hasExpectedPartDirective(
+          libraryUnit,
+          part,
+        );
         if (!hasLibraryPartDirectiveWithOutputUri) {
           // TODO: Upgrade to error in a future breaking change?
           log.warning(
@@ -163,8 +167,9 @@ class _Builder extends Builder {
           ..writeln()
           ..writeln(_headerLine)
           ..writeAll(
-            LineSplitter.split(item.generatorDescription)
-                .map((line) => '// $line\n'),
+            LineSplitter.split(
+              item.generatorDescription,
+            ).map((line) => '// $line\n'),
           )
           ..writeln(_headerLine)
           ..writeln();
@@ -176,8 +181,10 @@ class _Builder extends Builder {
     var genPartContent = contentBuffer.toString();
 
     try {
-      genPartContent =
-          formatOutput(genPartContent, library.languageVersion.effective);
+      genPartContent = formatOutput(
+        genPartContent,
+        library.languageVersion.effective,
+      );
     } catch (e, stack) {
       log.severe(
         '''
@@ -240,10 +247,7 @@ class SharedPartBuilder extends _Builder {
     super.additionalOutputExtensions,
     super.allowSyntaxErrors,
     super.writeDescriptions,
-  }) : super(
-          generatedExtension: '.$partId.g.part',
-          header: '',
-        ) {
+  }) : super(generatedExtension: '.$partId.g.part', header: '') {
     if (!_partIdRegExp.hasMatch(partId)) {
       throw ArgumentError.value(
         partId,
@@ -304,9 +308,7 @@ class PartBuilder extends _Builder {
     super.header,
     super.allowSyntaxErrors,
     super.options,
-  }) : super(
-          generatedExtension: generatedExtension,
-        );
+  }) : super(generatedExtension: generatedExtension);
 }
 
 /// A [Builder] which generates standalone Dart library files.