Skip to content

Commit 3a5de97

Browse files
authored
chore: Update github actions to Node 20 (#1874)
The only action that is still on Node 16 is the CLA action. I updated it from the Node 12 to Node 16 version though. Also, they changed the repo name, but I didn't see anything in the changelog about it. I did find the commit changing their readme though [here](contributor-assistant/github-action@b2a7f9f) The only action I saw with a breaking change was `upload-artifact`. We don't use any of the cases in this repo where the breaking change would effect us. [Migration guide](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md)
1 parent 65db969 commit 3a5de97

File tree

7 files changed

+21
-21
lines changed

7 files changed

+21
-21
lines changed

.github/workflows/audit-fix.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ jobs:
99
name: Run npm audit fix
1010
steps:
1111
- name: Checkout latest
12-
uses: actions/checkout@v3
12+
uses: actions/checkout@v4
1313
- name: Setup Node
14-
uses: actions/setup-node@v3
14+
uses: actions/setup-node@v4
1515
with:
1616
node-version-file: '.nvmrc'
1717
registry-url: 'https://registry.npmjs.org'
@@ -20,7 +20,7 @@ jobs:
2020
continue-on-error: true
2121
run: npm audit fix
2222
- name: Create Pull Request
23-
uses: peter-evans/create-pull-request@v5
23+
uses: peter-evans/create-pull-request@v6
2424
with:
2525
base: main
2626
title: 'chore: npm audit fix'

.github/workflows/cla.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
steps:
2121
- name: 'CLA Assistant'
2222
if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the CLA Document and I hereby sign the CLA') || github.event_name == 'pull_request_target'
23-
uses: cla-assistant/github-action@v2.2.0
23+
uses: contributor-assistant/github-action@v2.3.1
2424
env:
2525
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2626
PERSONAL_ACCESS_TOKEN: ${{ secrets.CLA_PERSONAL_ACCESS_TOKEN }}

.github/workflows/e2e.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,22 +23,22 @@ jobs:
2323
- name: Check installed fonts
2424
run: 'fc-list : family'
2525

26-
- uses: actions/checkout@v3
26+
- uses: actions/checkout@v4
2727

2828
- name: Run core server:${{ env.DOCKER_TAG }}
2929
run: |
3030
docker pull --quiet ghcr.io/deephaven/server:${{ env.DOCKER_TAG }}
3131
docker run --detach --publish 10000:10000 --name dh-core-server -v ./tests/docker-scripts/data:/data --env "START_OPTS=-Xmx4g -DAuthHandlers=io.deephaven.auth.AnonymousAuthenticationHandler -Ddeephaven.application.dir=./data/app.d" ghcr.io/deephaven/server:${{ env.DOCKER_TAG }}
3232
3333
- name: Use Node.js
34-
uses: actions/setup-node@v3
34+
uses: actions/setup-node@v4
3535
with:
3636
node-version-file: '.nvmrc'
3737
cache: 'npm'
3838

3939
- name: Cache node modules
4040
id: cache-node-modules
41-
uses: actions/cache@v3
41+
uses: actions/cache@v4
4242
with:
4343
path: |
4444
node_modules
@@ -62,7 +62,7 @@ jobs:
6262
run: PLAYWRIGHT_BROWSERS_PATH=0 npx playwright test --config=playwright-ci.config.ts
6363

6464
- name: Upload Playwright report
65-
uses: actions/upload-artifact@v3
65+
uses: actions/upload-artifact@v4
6666
if: always()
6767
with:
6868
name: playwright-report
@@ -73,7 +73,7 @@ jobs:
7373
run: docker logs dh-core-server > /tmp/server-log.txt
7474
- name: Upload server logs
7575
if: failure()
76-
uses: actions/upload-artifact@v3
76+
uses: actions/upload-artifact@v4
7777
with:
7878
name: server-logs
7979
path: /tmp/server-log.txt

.github/workflows/publish-alpha.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ jobs:
1818
packages: write
1919
id-token: write
2020
steps:
21-
- uses: actions/checkout@v3
21+
- uses: actions/checkout@v4
2222
with:
2323
fetch-depth: '0' # Need the history to properly select the canary version number
2424
ref: ${{ github.event.inputs.ref }}
25-
- uses: actions/setup-node@v3
25+
- uses: actions/setup-node@v4
2626
with:
2727
node-version-file: '.nvmrc'
2828
registry-url: 'https://registry.npmjs.org'

.github/workflows/publish-nightly.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
outputs:
1313
should_run: ${{ steps.should_run.outputs.should_run }}
1414
steps:
15-
- uses: actions/checkout@v3
15+
- uses: actions/checkout@v4
1616
- name: print latest_commit
1717
run: echo ${{ github.sha }}
1818

@@ -30,10 +30,10 @@ jobs:
3030
packages: write
3131
id-token: write
3232
steps:
33-
- uses: actions/checkout@v3
33+
- uses: actions/checkout@v4
3434
with:
3535
fetch-depth: '0' # Need the history to properly select the canary version number
36-
- uses: actions/setup-node@v3
36+
- uses: actions/setup-node@v4
3737
with:
3838
node-version-file: '.nvmrc'
3939
registry-url: 'https://registry.npmjs.org'

.github/workflows/publish-packages.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ jobs:
1212
id-token: write
1313
steps:
1414
- name: Checkout
15-
uses: actions/checkout@v3
15+
uses: actions/checkout@v4
1616
with:
1717
ref: ${{ github.ref }}
1818
- name: Setup Node
19-
uses: actions/setup-node@v3
19+
uses: actions/setup-node@v4
2020
with:
2121
node-version-file: '.nvmrc'
2222
registry-url: 'https://registry.npmjs.org'

.github/workflows/unit.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
group: ${{ github.workflow }}-${{ github.ref }}
1919
cancel-in-progress: true
2020
steps:
21-
- uses: actions/checkout@v3
21+
- uses: actions/checkout@v4
2222
with:
2323
fetch-depth: '0' # This action defaults to only getting the latest commit. Setting to 0 makes it retrieve the full git commit history
2424

@@ -27,13 +27,13 @@ jobs:
2727
run: git fetch --no-tags origin ${{ github.event.pull_request.base.ref }}
2828

2929
- name: Use Node.js
30-
uses: actions/setup-node@v3
30+
uses: actions/setup-node@v4
3131
with:
3232
node-version-file: '.nvmrc'
3333
cache: 'npm'
3434

3535
- name: Cache jest
36-
uses: actions/cache@v3
36+
uses: actions/cache@v4
3737
with:
3838
path: |
3939
.jest-cache
@@ -43,7 +43,7 @@ jobs:
4343
${{ runner.os }}-jestcache-
4444
4545
- name: Cache linters
46-
uses: actions/cache@v3
46+
uses: actions/cache@v4
4747
with:
4848
path: |
4949
.eslintcache
@@ -56,7 +56,7 @@ jobs:
5656
5757
- name: Cache node modules
5858
id: cache-node-modules
59-
uses: actions/cache@v3
59+
uses: actions/cache@v4
6060
with:
6161
path: |
6262
node_modules

0 commit comments

Comments
 (0)