fix(secret):create objectstore secret before calling scheduler deploy

Author: kmala

rootfs/api/models/app.py

@@ -478,6 +478,9 @@ def deploy(self, release, force_deploy=False, rollback_on_failure=True):  # noqa
         try:
             # create the application config in k8s (secret in this case) for all deploy objects
             self.set_application_config(release)
+            # only buildpack apps need access to object storage
+            if release.build.type == 'buildpack':
+                self.create_object_store_secret()
 
             # gather all proc types to be deployed
             tasks = [
@@ -1084,3 +1087,10 @@ def set_application_config(self, release):
             self._scheduler.secret.create(self.id, secret_name, secrets_env, labels=labels)
         else:
             self._scheduler.secret.update(self.id, secret_name, secrets_env, labels=labels)
+
+    def create_object_store_secret(self):
+        try:
+            self._scheduler.secret.get(self.id, 'objectstorage-keyfile')
+        except KubeException:
+            secret = self._scheduler.secret.get('deis', 'objectstorage-keyfile').json()
+            self._scheduler.secret.create(self.id, 'objectstorage-keyfile', secret['data'])

rootfs/scheduler/resources/pod.py

@@ -133,13 +133,6 @@ def manifest(self, namespace, name, image, **kwargs):
 
         # Check if it is a slug builder image.
         if build_type == "buildpack":
-            # only buildpack apps need access to object storage
-            try:
-                self.secret.get(namespace, 'objectstorage-keyfile')
-            except KubeException:
-                secret = self.secret.get('deis', 'objectstorage-keyfile').json()
-                self.secret.create(namespace, 'objectstorage-keyfile', secret['data'])
-
             # add the required volume to the top level pod spec
             spec['volumes'] = [{
                 'name': 'objectstorage-keyfile',