fix(task) subcommand parser skips global args

Author: Cre3per

cli/args/flags.rs

@@ -554,7 +554,15 @@ pub fn flags_from_vec(args: Vec<String>) -> clap::Result<Flags> {
     Some(("lsp", m)) => lsp_parse(&mut flags, m),
     Some(("repl", m)) => repl_parse(&mut flags, m),
     Some(("run", m)) => run_parse(&mut flags, m),
-    Some(("task", m)) => task_parse(&mut flags, m, &args),
+    Some(("task", m)) => task_parse(
+      &mut flags,
+      m,
+      // temporary workaround until https://github.com/clap-rs/clap/issues/1538 is fixed
+      &args[args
+        .iter()
+        .position(|el| el == matches.subcommand_name().unwrap())
+        .unwrap()..],
+    ),
     Some(("test", m)) => test_parse(&mut flags, m),
     Some(("types", m)) => types_parse(&mut flags, m),
     Some(("uninstall", m)) => uninstall_parse(&mut flags, m),
@@ -2561,6 +2569,9 @@ fn run_parse(flags: &mut Flags, matches: &clap::ArgMatches) {
   flags.subcommand = DenoSubcommand::Run(RunFlags { script });
 }
 
+/// raw_args is the subcommand's command line, eg. for the deno invocation
+/// `deno task echo`
+/// raw_args has value ["task", "echo"]
 fn task_parse(
   flags: &mut Flags,
   matches: &clap::ArgMatches,
@@ -2582,8 +2593,6 @@ fn task_parse(
   }
 
   if let Some(mut index) = matches.index_of("task_name_and_args") {
-    index += 1; // skip `task`
-
     // temporary workaround until https://github.com/clap-rs/clap/issues/1538 is fixed
     while index < raw_args.len() {
       match raw_args[index].as_str() {
@@ -5764,6 +5773,25 @@ mod tests {
     );
   }
 
+  #[test]
+  fn task_with_global_flags() {
+    // can fail if the custom parser in task_parse() starts at the wrong index
+    let r =
+      flags_from_vec(svec!["deno", "--quiet", "--unstable", "task", "build"]);
+    assert_eq!(
+      r.unwrap(),
+      Flags {
+        subcommand: DenoSubcommand::Task(TaskFlags {
+          cwd: None,
+          task: "build".to_string(),
+        }),
+        unstable: true,
+        log_level: Some(log::Level::Error),
+        ..Flags::default()
+      }
+    );
+  }
+
   #[test]
   fn task_subcommand_empty() {
     let r = flags_from_vec(svec!["deno", "task"]);