fix: device callback URL needs to handle a /

cardoe · cardoe · commit cb3f8a0afe52 · 2025-12-12T12:11:08.000-06:00
If the issuer path ends with a / the URL will be built wrong so we should instead use the helper function to ensure the path is built correctly. fixes #4242.
diff --git a/server/oauth2.go b/server/oauth2.go
@@ -491,7 +491,7 @@ func (s *Server) parseAuthorizationRequest(r *http.Request) (*storage.AuthReques
 		return nil, newDisplayedErr(http.StatusBadRequest, "Unregistered redirect_uri (%q).", redirectURI)
 	}
 	if redirectURI == deviceCallbackURI && client.Public {
-		redirectURI = s.issuerURL.Path + deviceCallbackURI
+		redirectURI = s.absPath(deviceCallbackURI)
 	}
 
 	// From here on out, we want to redirect back to the client with an error.

Original file line number	Diff line number	Diff line change
`@@ -491,7 +491,7 @@ func (s Server) parseAuthorizationRequest(r http.Request) (*storage.AuthReques`
`491`	`491`	`return nil, newDisplayedErr(http.StatusBadRequest, "Unregistered redirect_uri (%q).", redirectURI)`
`492`	`492`	`}`
`493`	`493`	`if redirectURI == deviceCallbackURI && client.Public {`
`494`		`- redirectURI = s.issuerURL.Path + deviceCallbackURI`
	`494`	`+ redirectURI = s.absPath(deviceCallbackURI)`
`495`	`495`	`}`
`496`	`496`
`497`	`497`	`// From here on out, we want to redirect back to the client with an error.`