Add --mac-address flag to network connect command

This adds support for specifying a MAC address when connecting
a container to a network, particularly useful for macvlan networks.

The flag follows the same pattern as existing network options like
--ip and --ip6, parsing and validating the MAC address before
sending it to the daemon via the EndpointSettings.MacAddress field.

Note: This requires a companion change in moby/moby to have the
daemon actually apply the MAC address during network conne

Signed-off-by: ahmedharabi <[email protected]>

Author: ahmedharabi

cli/command/network/connect.go

@@ -2,7 +2,11 @@ package network
 
 import (
 	"context"
+	"fmt"
+
 	"errors"
+
+
 	"net"
 	"net/netip"
 	"strings"
@@ -21,6 +25,7 @@ type connectOptions struct {
 	container    string
 	ipaddress    net.IP // TODO(thaJeztah): we need a flag-type to handle netip.Addr directly
 	ipv6address  net.IP // TODO(thaJeztah): we need a flag-type to handle netip.Addr directly
+	macAddress   net.HardwareAddr
 	links        opts.ListOpts
 	aliases      []string
 	linklocalips []net.IP // TODO(thaJeztah): we need a flag-type to handle []netip.Addr directly
@@ -32,6 +37,7 @@ func newConnectCommand(dockerCLI command.Cli) *cobra.Command {
 	options := connectOptions{
 		links: opts.NewListOpts(opts.ValidateLink),
 	}
+	var macStr string
 
 	cmd := &cobra.Command{
 		Use:   "connect [OPTIONS] NETWORK CONTAINER",
@@ -40,6 +46,15 @@ func newConnectCommand(dockerCLI command.Cli) *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			options.network = args[0]
 			options.container = args[1]
+			// Validate MAC address if provided
+
+			if macStr != "" {
+				mac, err := net.ParseMAC(macStr)
+				if err != nil {
+					return fmt.Errorf("invalid MAC address: %q", macStr)
+				}
+				options.macAddress = mac
+			}
 			return runConnect(cmd.Context(), dockerCLI.Client(), options)
 		},
 		ValidArgsFunction: func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
@@ -60,26 +75,34 @@ func newConnectCommand(dockerCLI command.Cli) *cobra.Command {
 	flags.IPSliceVar(&options.linklocalips, "link-local-ip", nil, "Add a link-local address for the container")
 	flags.StringSliceVar(&options.driverOpts, "driver-opt", []string{}, "driver options for the network")
 	flags.IntVar(&options.gwPriority, "gw-priority", 0, "Highest gw-priority provides the default gateway. Accepts positive and negative values.")
+	flags.StringVar(&macStr, "mac-address", "", "MAC address for the container on this network")
 	return cmd
 }
 
 func runConnect(ctx context.Context, apiClient client.NetworkAPIClient, options connectOptions) error {
 	driverOpts, err := convertDriverOpt(options.driverOpts)
+
 	if err != nil {
 		return err
 	}
+
+
+
+
 	_, err = apiClient.NetworkConnect(ctx, options.network, client.NetworkConnectOptions{
 		Container: options.container,
 		EndpointConfig: &network.EndpointSettings{
 			IPAMConfig: &network.EndpointIPAMConfig{
 				IPv4Address:  toNetipAddr(options.ipaddress),
 				IPv6Address:  toNetipAddr(options.ipv6address),
 				LinkLocalIPs: toNetipAddrSlice(options.linklocalips),
+
 			},
 			Links:      options.links.GetSlice(),
 			Aliases:    options.aliases,
 			DriverOpts: driverOpts,
 			GwPriority: options.gwPriority,
+			MacAddress : network.HardwareAddr(options.macAddress),
 		},
 	})
 	return err