Conversation
cli/command/container/rm.go
Outdated
There was a problem hiding this comment.
Not indeed. It can be either container id or container name, up to input from user. 😄
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
One nit comment but overall LGTM 🐸
cli/command/container/rm.go
Outdated
There was a problem hiding this comment.
Maybe container is better? it covers name and id 😄
Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
WeiZhang555
force-pushed
the
parallel-operations
branch
from
3e856b4 to
2b77325
Compare
|
I'm a bit concerned about this PR, but I might be missing something in the code. How does this impact the UX of the cmds? For example, how do we guarantee that the output isn't overlapping? Right now with cmds that take multiple containers as args there's a guarantee that the output will always be in a certain order, and it will follow the exact list of container IDs specified on the cmd line. This allows people to easily correlate which bit of output goes with which container. This PR appears to remove that guarantee, meaning the user then has to figure out which output goes with which container. Do we guarantee that ALL output from each kill/rm has enough uniquely identifying information (like the container name/id) in the output to always allow this correlation? |
|
@duglin don't worry, we have the output order gurantee 😄 . See #24761 (comment) in PR: #24761 I made a generic public function |
|
ok cool - wasn't sure from looking at the code. I did notice we show the errors/ID in the right order, but wasn't sure if there would ever be any other output that's sent to stderr/stdout. Guess not. |
|
@duglin I think the output should be right. What do you think of this? 😄 |
|
What's the current status? ping @mlaventure @thaJeztah |
|
This LGTM 👍 |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Tested this, and works as advertised
LGTM as well
|
Don't think we need documentation changes for this, other than a mention in the changelog |
Support parallel kill,rm
7 participants
Signed-off-by: Zhang Wei zhangwei555@huawei.com