overlay2: fix unmounting layer without merge dir#31069
Merged
vdemeester merged 1 commit intomoby:masterfrom Feb 17, 2017
Merged
overlay2: fix unmounting layer without merge dir#31069vdemeester merged 1 commit intomoby:masterfrom
vdemeester merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
fix-overlay2-unmount
branch
from
4fb74d5 to
e1af6c8
Compare
cpuguy83
approved these changes
Feb 17, 2017
Member
cpuguy83
left a comment
cpuguy83
left a comment
There was a problem hiding this comment.
Looks ok but why wouldn't there be a merge dir?
cpuguy83
reviewed
Feb 17, 2017
| "github.com/docker/docker/pkg/parsers" | ||
| "github.com/docker/docker/pkg/parsers/kernel" | ||
| "github.com/docker/go-units" | ||
| units "github.com/docker/go-units" |
dmcgowan
approved these changes
Feb 17, 2017
Member
dmcgowan
left a comment
dmcgowan
left a comment
There was a problem hiding this comment.
One of those situations where I would have thought this was already done
LGTM
vdemeester
approved these changes
Feb 17, 2017
| "github.com/docker/docker/pkg/parsers" | ||
| "github.com/docker/docker/pkg/parsers/kernel" | ||
| "github.com/docker/go-units" | ||
| units "github.com/docker/go-units" |
Member
|
cherry-picked into 17.03.1 through #31754 |
liusdu
pushed a commit
to liusdu/moby
that referenced
this pull request
Oct 30, 2017
cherry-pick from: moby#31069 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Lei Jitang <leijitang@huawei.com> (cherry picked from commit e1af6c8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dmcgowan
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com