Skip to content
This repository was archived by the owner on Feb 1, 2021. It is now read-only.

add support for docker volume ls & inspect#1196

Merged
chanwit merged 1 commit intodocker-archive:masterfrom
vieux:initial_volume_support
Sep 9, 2015
Merged

add support for docker volume ls & inspect#1196
chanwit merged 1 commit intodocker-archive:masterfrom
vieux:initial_volume_support

Conversation

@vieux
Copy link
Copy Markdown
Contributor

@vieux vieux commented Sep 4, 2015

Related to #1189

Add support for docker volume ls & docker volume inspect

@chanwit
Copy link
Copy Markdown
Contributor

chanwit commented Sep 5, 2015

@vieux are you going to have /volumes/json similar to /images/json in this PR?

@vieux
Copy link
Copy Markdown
Contributor Author

vieux commented Sep 5, 2015

@chanwit no because unfortunately, the engine didn't respect the same convention /cc @icecrime @cpuguy83

@chanwit
Copy link
Copy Markdown
Contributor

chanwit commented Sep 5, 2015

@vieux also does volume ls support --filter?
it's going to be similar to images when we'd like to filter by a node name (and maybe in another PR).

/cc @icecrime @cpuguy83

Signed-off-by: Victor Vieux <vieux@docker.com>
@cpuguy83
Copy link
Copy Markdown
Contributor

cpuguy83 commented Sep 8, 2015

@vieux We can have it follow the same convention, I think that makes sense. @icecrime ?

@vieux vieux changed the title [DO NOT MERGE] add support for docker volume ls & inspect add support for docker volume ls & inspect Sep 8, 2015
@vieux
Copy link
Copy Markdown
Contributor Author

vieux commented Sep 8, 2015

@cpuguy83 @icecrime as you want, I know the /json is ugly and not rest like (especially because we never did the /xml) but it would follow the same convention

@vieux
Copy link
Copy Markdown
Contributor Author

vieux commented Sep 8, 2015

@chanwit I think you should open an issue on https://github.com/docker/docker to propose --filter on volume

@vieux
Copy link
Copy Markdown
Contributor Author

vieux commented Sep 8, 2015

I think this one is good to merge as is as a 1st step /cc @abronan @chanwit @jimmyxian

@abronan
Copy link
Copy Markdown
Contributor

abronan commented Sep 8, 2015

👍 LGTM

@chanwit
Copy link
Copy Markdown
Contributor

chanwit commented Sep 9, 2015

LGTM

chanwit added a commit that referenced this pull request Sep 9, 2015
add support for docker volume ls & inspect
@chanwit chanwit merged commit 30cfdfb into docker-archive:master Sep 9, 2015
@vieux vieux deleted the initial_volume_support branch September 9, 2015 04:27
ChristianKniep pushed a commit to ChristianKniep/swarm that referenced this pull request Jul 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants