This repository was archived by the owner on Feb 1, 2021. It is now read-only.
DO NOT MERGE - REVIEW ONLY require username and password for swarm create#695
Closed
vieux wants to merge 1 commit intodocker-archive:masterfrom
vieux:create_auth
Closed
DO NOT MERGE - REVIEW ONLY require username and password for swarm create#695vieux wants to merge 1 commit intodocker-archive:masterfrom vieux:create_auth
vieux wants to merge 1 commit intodocker-archive:masterfrom
vieux:create_auth
Conversation
Contributor
Author
|
ping @abronan @aluzzardi @jlhawn |
Contributor
Author
|
I know the tests are broken, I did it on purpose so we don't merge. |
Contributor
|
As discussed IRL, how about having |
Contributor
|
Also, this set aside, how about moving from discovery-staging to discovery? |
Contributor
Author
|
I agree on the destroy but let's change the url in another PR |
Contributor
|
How about this workflow: |
update Godeps add destroy command Signed-off-by: Victor Vieux <victorvieux@gmail.com>
Contributor
Author
|
@vieux Do we need to update the user-facing documentation for this? I saw you hit the token README |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #695
The server side part, isn't live yet please review the code.
Added a
-u,--usernameand-p.--passwordtoswarm createAlternatively you can do a swarm create and it will ask for the username and password (without echo, like docker login)
You can combine with: