Skip to content
This repository was archived by the owner on Feb 1, 2021. It is now read-only.

DO NOT MERGE - REVIEW ONLY require username and password for swarm create#695

Closed
vieux wants to merge 1 commit intodocker-archive:masterfrom
vieux:create_auth
Closed

DO NOT MERGE - REVIEW ONLY require username and password for swarm create#695
vieux wants to merge 1 commit intodocker-archive:masterfrom
vieux:create_auth

Conversation

@vieux
Copy link
Copy Markdown
Contributor

@vieux vieux commented May 1, 2015

Close #695

The server side part, isn't live yet please review the code.

Added a -u,--username and -p.--password to swarm create
Alternatively you can do a swarm create and it will ask for the username and password (without echo, like docker login)

You can combine with:

$ swarm create -u vieux
Password:

53128764320641268482352786912

@vieux
Copy link
Copy Markdown
Contributor Author

vieux commented May 1, 2015

ping @abronan @aluzzardi @jlhawn

@vieux
Copy link
Copy Markdown
Contributor Author

vieux commented May 1, 2015

I know the tests are broken, I did it on purpose so we don't merge.

@aluzzardi
Copy link
Copy Markdown
Contributor

As discussed IRL, how about having destroy as well, requiring the same auth (both client and server side)

@aluzzardi
Copy link
Copy Markdown
Contributor

Also, this set aside, how about moving from discovery-staging to discovery?

@vieux
Copy link
Copy Markdown
Contributor Author

vieux commented May 6, 2015

I agree on the destroy but let's change the url in another PR

@aluzzardi
Copy link
Copy Markdown
Contributor

How about this workflow:

$ swarm create
Warning: Anonymous cluster created. Anonymous clusters can be destroyed by anyone with knowledge of the token. Please provide a `--username` in order to create an authenticated cluster.
53128764320641268482352786912
$ swarm create -u vieux
Password:
53128764320641268482352786912

/cc @bfirsh @shykes

update Godeps
add destroy command

Signed-off-by: Victor Vieux <victorvieux@gmail.com>
@vieux
Copy link
Copy Markdown
Contributor Author

vieux commented May 29, 2015

ping @bfirsh @shykes

@aluzzardi aluzzardi modified the milestones: 0.3.0, 0.4.0 Jun 29, 2015
@moxiegirl
Copy link
Copy Markdown

@vieux Do we need to update the user-facing documentation for this? I saw you hit the token README

@aluzzardi aluzzardi modified the milestones: 0.4.0, 0.5.0 Aug 11, 2015
@vieux vieux closed this Oct 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants