validate duplicate published port in ServiceSpec#1495
Merged
dperny merged 1 commit intomoby:masterfrom Sep 6, 2016
Merged
Conversation
Signed-off-by: allencloud <allen.sun@daocloud.io>
Current coverage is 55.34% (diff: 100%)@@ master #1495 diff @@
==========================================
Files 82 82
Lines 12873 12873
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7118 7125 +7
+ Misses 4767 4765 -2
+ Partials 988 983 -5
|
Collaborator
|
ping @mrjana |
Contributor
|
LGTM |
Collaborator
|
LGTM ping @cpuguy83 PTAL |
Member
|
LGTM |
|
Hi, has anybody come across an issue when registering a service using udp & tcp on the same port? "Error response from daemon: rpc error: code = 3 desc = EndpointSpec: duplicate published ports provided" This has started happening with v1.12.2 and was fine with v1.12.1 I'm running the service with |
Collaborator
|
@jamesdmorgan: Thank you for pointing this out. I opened #1632 to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #1494
Currently, swarmkit checks the whole
*portto avoid duplication.This PR makes swarmkit to check the published port of
PortConfig.Signed-off-by: allencloud allen.sun@daocloud.io