Skip to content

validate duplicate published port in ServiceSpec#1495

Merged
dperny merged 1 commit intomoby:masterfrom
allencloud:validate-dupicated-published-ports
Sep 6, 2016
Merged

validate duplicate published port in ServiceSpec#1495
dperny merged 1 commit intomoby:masterfrom
allencloud:validate-dupicated-published-ports

Conversation

@allencloud
Copy link
Copy Markdown
Contributor

fixed #1494

Currently, swarmkit checks the whole *port to avoid duplication.

This PR makes swarmkit to check the published port of PortConfig.

Signed-off-by: allencloud allen.sun@daocloud.io

Signed-off-by: allencloud <allen.sun@daocloud.io>
@codecov-io
Copy link
Copy Markdown

Current coverage is 55.34% (diff: 100%)

Merging #1495 into master will increase coverage by 0.05%

@@             master      #1495   diff @@
==========================================
  Files            82         82          
  Lines         12873      12873          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           7118       7125     +7   
+ Misses         4767       4765     -2   
+ Partials        988        983     -5   

Sunburst

Powered by Codecov. Last update 586bf3a...8dd4c69

@aaronlehmann
Copy link
Copy Markdown
Collaborator

ping @mrjana

@mrjana
Copy link
Copy Markdown
Contributor

mrjana commented Sep 6, 2016

LGTM

@aaronlehmann
Copy link
Copy Markdown
Collaborator

LGTM

ping @cpuguy83 PTAL

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Sep 6, 2016

LGTM

@jamesdmorgan
Copy link
Copy Markdown

jamesdmorgan commented Oct 13, 2016

Hi, has anybody come across an issue when registering a service using udp & tcp on the same port?

"Error response from daemon: rpc error: code = 3 desc = EndpointSpec: duplicate published ports provided"

This has started happening with v1.12.2 and was fine with v1.12.1

I'm running the service with

-p 5555:5555/tcp
-p 5555:5555/udp
-p 5556:5556/tcp

@aaronlehmann
Copy link
Copy Markdown
Collaborator

@jamesdmorgan: Thank you for pointing this out. I opened #1632 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service creating allows for two same published port in VirtualIp mode?

8 participants