Skip to content

Commit fc52852

Browse files
lrstewartdougch
authored andcommitted
tests: fix flaky ja4 test (aws#5169)
1 parent f2ef3f0 commit fc52852

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

tests/unit/s2n_fingerprint_ja4_test.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,11 @@ static S2N_RESULT s2n_test_ja4_hash_from_cipher_count(uint16_t cipher_count,
145145
};
146146
RESULT_GUARD_POSIX(s2n_stuffer_write_bytes(&bytes, before_ciphers, sizeof(before_ciphers)));
147147

148-
size_t ciphers_size = cipher_count * S2N_TLS_CIPHER_SUITE_LEN;
148+
size_t ciphers_size = cipher_count * sizeof(uint16_t);
149149
RESULT_GUARD_POSIX(s2n_stuffer_write_uint16(&bytes, ciphers_size));
150-
RESULT_GUARD_POSIX(s2n_stuffer_skip_write(&bytes, ciphers_size));
150+
for (size_t i = 0; i < cipher_count; i++) {
151+
RESULT_GUARD_POSIX(s2n_stuffer_write_uint16(&bytes, 0));
152+
}
151153

152154
uint8_t after_ciphers[] = {
153155
S2N_TEST_CLIENT_HELLO_AFTER_CIPHERS,

0 commit comments

Comments
 (0)