Skip to content

Commit f4923b9

Browse files
committed
Remove tasks start and exit with code 0 notifications
Signed-off-by: Amiram Wingarten <[email protected]>
1 parent e95311d commit f4923b9

File tree

1 file changed

+12
-18
lines changed

1 file changed

+12
-18
lines changed

packages/task/src/browser/task-service.ts

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
import { ApplicationShell, FrontendApplication, WidgetManager, WidgetOpenMode } from '@theia/core/lib/browser';
1818
import { open, OpenerService } from '@theia/core/lib/browser/opener-service';
19-
import { ILogger, CommandService } from '@theia/core/lib/common';
19+
import { CommandService, ILogger } from '@theia/core/lib/common';
2020
import { MessageService } from '@theia/core/lib/common/message-service';
2121
import { Deferred } from '@theia/core/lib/common/promise-util';
2222
import { QuickPickItem, QuickPickService } from '@theia/core/lib/common/quick-pick-service';
@@ -32,24 +32,24 @@ import { WorkspaceService } from '@theia/workspace/lib/browser/workspace-service
3232
import { inject, injectable, named, postConstruct } from 'inversify';
3333
import { DiagnosticSeverity, Range } from 'vscode-languageserver-types';
3434
import {
35+
ApplyToKind,
36+
BackgroundTaskEndedEvent,
37+
DependsOrder,
3538
NamedProblemMatcher,
3639
ProblemMatchData,
3740
ProblemMatcher,
41+
RevealKind,
3842
RunTaskOption,
3943
TaskConfiguration,
44+
TaskConfigurationScope,
4045
TaskCustomization,
41-
TaskExitedEvent,
42-
TaskInfo,
43-
TaskOutputProcessedEvent,
44-
BackgroundTaskEndedEvent,
4546
TaskDefinition,
46-
TaskServer,
47+
TaskExitedEvent,
4748
TaskIdentifier,
48-
DependsOrder,
49-
RevealKind,
50-
ApplyToKind,
49+
TaskInfo,
5150
TaskOutputPresentation,
52-
TaskConfigurationScope
51+
TaskOutputProcessedEvent,
52+
TaskServer
5353
} from '../common';
5454
import { TaskWatcher } from '../common/task-watcher';
5555
import { ProvidedTaskConfigurations } from './provided-task-configurations';
@@ -203,9 +203,6 @@ export class TaskService implements TaskConfigurationClient {
203203
terminateSignal: new Deferred<string | undefined>(),
204204
isBackgroundTaskEnded: new Deferred<boolean | undefined>()
205205
});
206-
const taskConfig = event.config;
207-
const taskIdentifier = taskConfig ? this.getTaskIdentifier(taskConfig) : event.taskId.toString();
208-
this.messageService.info(`Task '${taskIdentifier}' has been started.`);
209206
});
210207

211208
this.taskWatcher.onOutputProcessed(async (event: TaskOutputProcessedEvent) => {
@@ -300,10 +297,7 @@ export class TaskService implements TaskConfigurationClient {
300297
const taskConfig = event.config;
301298
const taskIdentifier = taskConfig ? this.getTaskIdentifier(taskConfig) : event.taskId.toString();
302299
if (event.code !== undefined) {
303-
const message = `Task '${taskIdentifier}' has exited with code ${event.code}.`;
304-
if (event.code === 0) {
305-
this.messageService.info(message);
306-
} else {
300+
if (event.code !== 0) {
307301
const eventTaskConfig = event.config;
308302
if (eventTaskConfig && eventTaskConfig.presentation && eventTaskConfig.presentation.reveal === RevealKind.Silent && event.terminalId) {
309303
const terminal = this.terminalService.getByTerminalId(event.terminalId);
@@ -316,7 +310,7 @@ export class TaskService implements TaskConfigurationClient {
316310
}
317311
}
318312
}
319-
this.messageService.error(message);
313+
this.messageService.error(`Task '${taskIdentifier}' has exited with code ${event.code}.`);
320314
}
321315
} else if (event.signal !== undefined) {
322316
this.messageService.info(`Task '${taskIdentifier}' was terminated by signal ${event.signal}.`);

0 commit comments

Comments
 (0)