Remove Generator in _prune_old_outbound_device_pokes (#17814)

realtyem · web-flow · commit 47fe6df01344 · 2024-10-30T21:21:22.000-05:00
Context: matrix-org/synapse#15439 (#15439) Also see discussion in #17813
diff --git a/changelog.d/17814.bugfix b/changelog.d/17814.bugfix
@@ -0,0 +1 @@
+Avoid lost data on some database query retries.
diff --git a/synapse/storage/databases/main/devices.py b/synapse/storage/databases/main/devices.py
@@ -1422,7 +1422,7 @@ def _prune_txn(txn: LoggingTransaction) -> None:
                 DELETE FROM device_lists_outbound_last_success
                 WHERE destination = ? AND user_id = ?
             """
-            txn.execute_batch(sql, ((row[0], row[1]) for row in rows))
+            txn.execute_batch(sql, [(row[0], row[1]) for row in rows])
 
             logger.info("Pruned %d device list outbound pokes", count)
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Avoid lost data on some database query retries.`