Avoid registering babel-plugin-ember-template-compilation repeatedly

Author: dfreeman

lib/utils.js

@@ -25,12 +25,13 @@ const INLINE_PRECOMPILE_MODULES = Object.freeze({
 function isInlinePrecompileBabelPluginRegistered(plugins) {
   return plugins.some((plugin) => {
     if (Array.isArray(plugin)) {
-      let [pluginPathOrInstance, options] = plugin;
+      let [pluginPathOrInstance, options, key] = plugin;
 
       return (
-        pluginPathOrInstance === require.resolve('babel-plugin-htmlbars-inline-precompile') &&
-        typeof options.modules === 'object' &&
-        options.modules['ember-cli-htmlbars'] === 'hbs'
+        (pluginPathOrInstance === require.resolve('babel-plugin-htmlbars-inline-precompile') ||
+          pluginPathOrInstance === require.resolve('babel-plugin-ember-template-compilation')) &&
+        typeof options === 'object' &&
+        key === 'ember-cli-htmlbars:inline-precompile'
       );
     } else if (
       plugin !== null &&

node-tests/utils_test.js

@@ -166,6 +166,36 @@ describe('utils', function () {
     });
   });
 
+  describe('isInlinePrecompileBabelPluginRegistered', function () {
+    it('is false when no plugins exist', function () {
+      let plugins = [];
+
+      assert.strictEqual(utils.isInlinePrecompileBabelPluginRegistered(plugins), false);
+    });
+
+    it('detects when the htmlbars-inline-precompile plugin exists', function () {
+      let plugins = [
+        utils.setup({}, { requiresModuleApiPolyfill: true, templateCompilerPath: '.' }),
+      ];
+
+      assert.strictEqual(utils.isInlinePrecompileBabelPluginRegistered(plugins), true);
+    });
+
+    it('detects when the ember-template-compilation plugin exists', function () {
+      let plugins = [
+        utils.setup({}, { requiresModuleApiPolyfill: false, templateCompilerPath: '.' }),
+      ];
+
+      assert.strictEqual(utils.isInlinePrecompileBabelPluginRegistered(plugins), true);
+    });
+
+    it('detects when the parallelized plugin exists', function () {
+      let plugins = [utils.buildParalleizedBabelPlugin({}, {}, '', false, true)];
+
+      assert.strictEqual(utils.isInlinePrecompileBabelPluginRegistered(plugins), true);
+    });
+  });
+
   describe('isColocatedBabelPluginRegistered', function () {
     it('is false when no plugins exist', function () {
       let plugins = [];