Improved regexp responsible for label extraction in Chrome (#1966)

chnakamura · Andarist · web-flow · commit 4979ebb2f9db · 2020-08-10T22:57:57.000+02:00
* Updated the regex query

* Add changeset

Co-authored-by: Mateusz Burzyński &lt;mateuszburzynski@gmail.com&gt;
diff --git a/.changeset/blue-pianos-smell.md b/.changeset/blue-pianos-smell.md
@@ -0,0 +1,5 @@
+---
+"@emotion/core": patch
+---
+
+Fixed label extraction from the stack traces in Chrome in certain scenarios. This has affected only development builds.
diff --git a/packages/core/src/jsx.js b/packages/core/src/jsx.js
@@ -154,7 +154,7 @@ export const jsx: typeof React.createElement = function(
     if (error.stack) {
       // chrome
       let match = error.stack.match(
-        /at (?:Object\.|)jsx.*\n\s+at ([A-Z][A-Za-z$]+) /
+        /at (?:Object\.|Module\.|)jsx.*\n\s+at ([A-Z][A-Za-z$]+) /
       )
       if (!match) {
         // safari and firefox

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@emotion/core": patch
 +---
++
 +Fixed label extraction from the stack traces in Chrome in certain scenarios. This has affected only development builds.
Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ export const jsx: typeof React.createElement = function(`
`154`	`154`	`if (error.stack) {`
`155`	`155`	`// chrome`
`156`	`156`	`let match = error.stack.match(`
`157`		`- /at (?:Object\.\|)jsx.*\n\s+at ([A-Z][A-Za-z$]+) /`
	`157`	`+ /at (?:Object\.\|Module\.\|)jsx.*\n\s+at ([A-Z][A-Za-z$]+) /`
`158`	`158`	`)`
`159`	`159`	`if (!match) {`
`160`	`160`	`// safari and firefox`