[Fix] Uint8Array.prototype.setFromBase64: avoid invoking toString on a non-string string argument

ljharb · ljharb · commit ef9624916544 · 2024-02-28T15:05:58.000-08:00
Also: - add test coverage from tc39/test262#3994
diff --git a/.eslintrc b/.eslintrc
@@ -18,6 +18,7 @@
 			"capIsNewExceptions": [
 				"FromBase64",
 				"FromHex",
+				"DetachArrayBuffer",
 				"Get",
 				"GetIntrinsic",
 				"GetOptionsObject",
diff --git a/Uint8Array.prototype.setFromBase64/implementation.js b/Uint8Array.prototype.setFromBase64/implementation.js
@@ -29,7 +29,7 @@ module.exports = function setFromBase64(string) {
 	ValidateUint8Array(into); // step 2
 
 	if (typeof string !== 'string') {
-		throw new $TypeError('`string` is not a string: ' + string); // step 3
+		throw new $TypeError('`string` is not a string: ' + typeof string); // step 3
 	}
 
 	var opts = GetOptionsObject(arguments.length > 1 ? arguments[1] : void undefined); // step 4
@@ -41,7 +41,7 @@ module.exports = function setFromBase64(string) {
 	}
 
 	if (typeof alphabet !== 'string') {
-		throw new $TypeError('`alphabet` is not a string: ' + alphabet); // step 7
+		throw new $TypeError('`alphabet` is not a string: ' + typeof alphabet); // step 7
 	}
 
 	if (alphabet !== 'base64' && alphabet !== 'base64url') {
diff --git a/package.json b/package.json
@@ -69,6 +69,7 @@
 		"evalmd": "^0.0.19",
 		"for-each": "^0.3.3",
 		"in-publish": "^2.0.1",
+		"is-core-module": "^2.13.1",
 		"npmignore": "^0.3.1",
 		"nyc": "^10.3.2",
 		"object-inspect": "^1.13.1",
diff --git a/test/Uint8Array.prototype.setFromBase64.js b/test/Uint8Array.prototype.setFromBase64.js

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ module.exports = function setFromBase64(string) {`
`29`	`29`	`ValidateUint8Array(into); // step 2`
`30`	`30`
`31`	`31`	`if (typeof string !== 'string') {`
`32`		- throw new $TypeError('`string` is not a string: ' + string); // step 3
	`32`	+ throw new $TypeError('`string` is not a string: ' + typeof string); // step 3
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`var opts = GetOptionsObject(arguments.length > 1 ? arguments[1] : void undefined); // step 4`
`@@ -41,7 +41,7 @@ module.exports = function setFromBase64(string) {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`if (typeof alphabet !== 'string') {`
`44`		- throw new $TypeError('`alphabet` is not a string: ' + alphabet); // step 7
	`44`	+ throw new $TypeError('`alphabet` is not a string: ' + typeof alphabet); // step 7
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`if (alphabet !== 'base64' && alphabet !== 'base64url') {`