another round of changes from code review

Author: pertrai1

concepts/template-strings/about.md

@@ -1,9 +1,9 @@
-# About
+# Introduction
 
 In JavaScript, _template strings_ allows for embedding expressions in strings, also referred to as string interpolation.
 This functionality extends the functionality of the built in [`String`][string-reference] global object.
 
-You can create template strings in javascript by wrapping text in backticks.
+You can create template strings in JavaScript by wrapping text in backticks.
 They not only allow the text to include new lines and other special characters, you can also embed variables and other expressions.
 
 ```javascript
@@ -34,6 +34,10 @@ strings to accomplish multiple
 lines`;
 ```
 
+With the substitution capabilities that are available, you can also introduce logic into the process to determine what the output string should be.
+One way to handle the logic could be using the [ternary operator][ternary-operator].
+This gives the same conditional `if/else` functionality in a slightly different format.
+
 To implement logic into template string syntax:
 
 ```javascript
@@ -45,3 +49,4 @@ const grade = 95;
 
 [string-reference]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String
 [type-conversion-concept]: /tracks/javascript/concepts/type-conversion
+[ternary-operator]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Conditional_Operator

concepts/template-strings/introduction.md

@@ -3,7 +3,7 @@
 In JavaScript, _template strings_ allows for embedding expressions in strings, also referred to as string interpolation.
 This functionality extends the functionality of the built in [`String`][string-reference] global object.
 
-You can create template strings in javascript by wrapping text in backticks.
+You can create template strings in JavaScript by wrapping text in backticks.
 They not only allow the text to include new lines and other special characters, you can also embed variables and other expressions.
 
 ```javascript
@@ -34,6 +34,10 @@ strings to accomplish multiple
 lines`;
 ```
 
+With the substitution capabilities that are available, you can also introduce logic into the process to determine what the output string should be.
+One way to handle the logic could be using the [ternary operator][ternary-operator].
+This gives the same conditional `if/else` functionality in a slightly different format.
+
 To implement logic into template string syntax:
 
 ```javascript
@@ -45,3 +49,4 @@ const grade = 95;
 
 [string-reference]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String
 [type-conversion-concept]: /tracks/javascript/concepts/type-conversion
+[ternary-operator]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Conditional_Operator

exercises/concept/custom-signs/.docs/hints.md

@@ -15,12 +15,11 @@
 
 ## 5. Compute the cost of a sign
 
-- Figure out the [`length`][mdn-string-length] of the characters that can be _parsed_ and return a _floating point_ number.
-- Once you have the [floating point][mdn-parse-float] number, you will need to set it to only show the first two numbers using [fixed-point][mdn-to-fixed] notation.
+- Figure out the [`length`][mdn-string-length] of the characters.
+- Only show the first two decimal numbers using [fixed-point][mdn-to-fixed] notation.
 
 [mdn-const]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const
 [mdn-template-strings]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
 [mdn-string-length]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/length
-[mdn-parse-float]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseFloat
 [mdn-to-fixed]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed
 [mdn-ternary-operator]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Conditional_Operator

exercises/concept/custom-signs/.docs/instructions.md

@@ -34,7 +34,9 @@ graduationFor('Hannah', 2022);
 
 ## 5. Compute the cost of a sign
 
-Implement the function `costOf(sign, currency)` which takes a string that holds the contents of the sign and a string that represents the currency and returns a phrase that includes the cost to create the sign, formatted with a fixed point notation set to 2 points, followed by the currency string.
+Implement the function `costOf(sign, currency)` which takes a string that holds the contents of the sign and a string that represents the currency.
+The cost is calculated based on each letter in the sign costing two dollars with an additional 20 dollars for the sign created.
+The phrase returned includes the cost to create the sign, formatted with a fixed point notation set to 2 points, followed by the currency string.
 
 ```javascript
 costOf('Congratulations Rob Class of 2021', 'dollars');

exercises/concept/custom-signs/.docs/introduction.md

@@ -3,7 +3,7 @@
 In JavaScript, _template strings_ allows for embedding expressions in strings, also referred to as string interpolation.
 This functionality extends the functionality of the built in [`String`][string-reference] global object.
 
-You can create template strings in javascript by wrapping text in backticks.
+You can create template strings in JavaScript by wrapping text in backticks.
 They not only allow the text to include new lines and other special characters, you can also embed variables and other expressions.
 
 ```javascript
@@ -34,6 +34,10 @@ strings to accomplish multiple
 lines`;
 ```
 
+With the substitution capabilities that are available, you can also introduce logic into the process to determine what the output string should be.
+One way to handle the logic could be using the [ternary operator][ternary-operator].
+This gives the same conditional `if/else` functionality in a slightly different format.
+
 To implement logic into template string syntax:
 
 ```javascript
@@ -45,3 +49,4 @@ const grade = 95;
 
 [string-reference]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String
 [type-conversion-concept]: /tracks/javascript/concepts/type-conversion
+[ternary-operator]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Conditional_Operator

exercises/concept/custom-signs/.meta/config.json

@@ -1,5 +1,5 @@
 {
-  "blurb": "Learn about characters by helping a sign company create custom messages for their signs.",
+  "blurb": "Learn about template strings and the ternary operator ...",
   "authors": ["pertrai1"],
   "contributors": [],
   "files": {

exercises/concept/custom-signs/.meta/exemplar.js

@@ -16,6 +16,5 @@ export function graduationFor(name, year) {
 }
 
 export function costOf(sign, currency = 'dollars') {
-  const convertedSign = Number.parseFloat(sign.length);
-  return `Your sign cost ${(convertedSign * 2 + 20).toFixed(2)} ${currency}`;
+  return `Your sign cost ${(sign.length * 2 + 20).toFixed(2)} ${currency}`;
 }

exercises/concept/custom-signs/custom-signs.js

@@ -5,7 +5,7 @@
 // implementing this exercise.
 
 /**
- * Build a string that includes both of the parameters.
+ * Build a sign that includes both of the parameters.
  *
  * @param {string} occasion
  * @param {string} name
@@ -18,7 +18,7 @@ export function buildSign(occasion, name) {
 }
 
 /**
- * Build a string that conditionally formats the return string.
+ * Build a birthday sign that conditionally formats the return string.
  *
  * @param {number} age
  *
@@ -30,7 +30,7 @@ export function buildBirthdaySign(age) {
 }
 
 /**
- * Build a string formatted on multiple lines.
+ * Build a graduation sign that includes multiple lines.
  *
  * @param {string} name
  * @param {number} year
@@ -49,7 +49,7 @@ export function graduationFor(name, year) {
  * @param {string} sign
  * @param {string} currency
  *
- * @returns {number} cost to create the sign
+ * @returns {string} cost to create the sign
  */
 
 export function costOf(sign, currency) {

exercises/concept/custom-signs/custom-signs.spec.js

@@ -9,7 +9,10 @@ import {
 
 describe('buildSign', () => {
   test('occasion is Birthday', () => {
-    expect(buildSign('Birthday', 'Rob')).toBe('Happy Birthday Rob!');
+    expect(buildSign('Birthday', 'Jack')).toBe('Happy Birthday Jack!');
+  });
+  test('occasion is Anniversary', () => {
+    expect(buildSign('Anniversary', 'Jill')).toBe('Happy Anniversary Jill!');
   });
 });