✅ Update test to add verification database records (#43)

Author: estebanx64

backend/app/tests/api/routes/test_login.py

@@ -1,8 +1,11 @@
 from unittest.mock import patch
 
 from fastapi.testclient import TestClient
+from sqlmodel import Session, select
 
 from app.core.config import settings
+from app.core.security import verify_password
+from app.models import User
 from app.utils import generate_password_reset_token
 
 
@@ -67,7 +70,7 @@ def test_recovery_password_user_not_exits(
 
 
 def test_reset_password(
-    client: TestClient, superuser_token_headers: dict[str, str]
+    client: TestClient, superuser_token_headers: dict[str, str], db: Session
 ) -> None:
     token = generate_password_reset_token(email=settings.FIRST_SUPERUSER)
     data = {"new_password": "changethis", "token": token}
@@ -79,6 +82,11 @@ def test_reset_password(
     assert r.status_code == 200
     assert r.json() == {"message": "Password updated successfully"}
 
+    user_query = select(User).where(User.email == settings.FIRST_SUPERUSER)
+    user = db.exec(user_query).first()
+    assert user
+    assert verify_password(data["new_password"], user.hashed_password)
+
 
 def test_reset_password_invalid_token(
     client: TestClient, superuser_token_headers: dict[str, str]

backend/app/tests/api/routes/test_teams.py

@@ -1,11 +1,11 @@
 from typing import Any
 
 from fastapi.testclient import TestClient
-from sqlmodel import Session
+from sqlmodel import Session, select
 
 from app.core.config import settings
 from app.crud import add_user_to_team
-from app.models import Role
+from app.models import Role, Team, UserTeamLink
 from app.tests.utils.team import create_random_team
 from app.tests.utils.user import create_user, user_authentication_headers
 
@@ -108,7 +108,7 @@ def test_read_team_not_found(client: TestClient) -> None:
     assert data["detail"] == "Team not found for the current user"
 
 
-def test_create_team(client: TestClient) -> None:
+def test_create_team(client: TestClient, db: Session) -> None:
     user_auth_headers = user_authentication_headers(
         client=client,
         email=settings.FIRST_SUPERUSER,
@@ -128,6 +128,12 @@ def test_create_team(client: TestClient) -> None:
     assert data["name"] == team_in["name"]
     assert data["description"] == team_in["description"]
 
+    team_query = select(Team).where(Team.id == data["id"])
+    team_db = db.exec(team_query).first()
+    assert team_db
+    assert team_db.name == team_in["name"]
+    assert team_db.description == team_in["description"]
+
 
 def test_update_team(client: TestClient, db: Session) -> None:
     team = create_random_team(db)
@@ -224,6 +230,10 @@ def test_delete_team(client: TestClient, db: Session) -> None:
     data = response.json()
     assert data["message"] == "Team deleted"
 
+    team_query = select(Team).where(Team.id == team.id)
+    team_db = db.exec(team_query).first()
+    assert team_db is None
+
 
 def test_delete_team_not_found(client: TestClient) -> None:
     user_auth_headers = user_authentication_headers(
@@ -392,6 +402,14 @@ def test_update_member_in_team(client: TestClient, db: Session) -> None:
     assert data["team"]["id"] == team.id
     assert data["user"]["id"] == user.id
 
+    user_team_query = select(UserTeamLink).where(UserTeamLink.user == user)
+    user_team_db = db.exec(user_team_query).first()
+    db.refresh(user_team_db)
+    assert user_team_db
+    assert user_team_db.role == data["role"]
+    assert user_team_db.team_id == data["team"]["id"]
+    assert user_team_db.user_id == data["user"]["id"]
+
 
 def test_update_member_in_team_not_enough_permissions(
     client: TestClient, db: Session
@@ -478,6 +496,10 @@ def test_remove_member_from_team(client: TestClient, db: Session) -> None:
     data = response.json()
     assert data["message"] == "User removed from team"
 
+    user_team_query = select(UserTeamLink).where(UserTeamLink.user == user_member)
+    user_team_db = db.exec(user_team_query).first()
+    assert not user_team_db
+
 
 def test_remove_member_from_team_not_enough_permissions(
     client: TestClient, db: Session

backend/app/tests/api/routes/test_users.py

@@ -1,11 +1,12 @@
 from unittest.mock import patch
 
 from fastapi.testclient import TestClient
-from sqlmodel import Session
+from sqlmodel import Session, select
 
 from app import crud
 from app.core.config import settings
-from app.models import UserCreate
+from app.core.security import verify_password
+from app.models import User, UserCreate
 from app.tests.utils.utils import random_email, random_lower_string
 
 
@@ -167,7 +168,7 @@ def test_retrieve_users(
 
 
 def test_update_user_me(
-    client: TestClient, normal_user_token_headers: dict[str, str]
+    client: TestClient, normal_user_token_headers: dict[str, str], db: Session
 ) -> None:
     full_name = "Updated Name"
     email = random_email()
@@ -182,9 +183,15 @@ def test_update_user_me(
     assert updated_user["email"] == email
     assert updated_user["full_name"] == full_name
 
+    user_query = select(User).where(User.email == email)
+    user_db = db.exec(user_query).first()
+    assert user_db
+    assert user_db.email == email
+    assert user_db.full_name == full_name
+
 
 def test_update_password_me(
-    client: TestClient, superuser_token_headers: dict[str, str]
+    client: TestClient, superuser_token_headers: dict[str, str], db: Session
 ) -> None:
     new_password = random_lower_string()
     data = {
@@ -200,6 +207,12 @@ def test_update_password_me(
     updated_user = r.json()
     assert updated_user["message"] == "Password updated successfully"
 
+    user_query = select(User).where(User.email == settings.FIRST_SUPERUSER)
+    user_db = db.exec(user_query).first()
+    assert user_db
+    assert user_db.email == settings.FIRST_SUPERUSER
+    assert verify_password(new_password, user_db.hashed_password)
+
     # Revert to the old password to keep consistency in test
     old_data = {
         "current_password": new_password,
@@ -210,7 +223,10 @@ def test_update_password_me(
         headers=superuser_token_headers,
         json=old_data,
     )
+    db.refresh(user_db)
+
     assert r.status_code == 200
+    assert verify_password(settings.FIRST_SUPERUSER_PASSWORD, user_db.hashed_password)
 
 
 def test_update_password_me_incorrect_password(
@@ -265,7 +281,7 @@ def test_update_password_me_same_password_error(
     )
 
 
-def test_register_user(client: TestClient) -> None:
+def test_register_user(client: TestClient, db: Session) -> None:
     with patch("app.core.config.settings.USERS_OPEN_REGISTRATION", True):
         username = random_email()
         password = random_lower_string()
@@ -280,6 +296,13 @@ def test_register_user(client: TestClient) -> None:
         assert created_user["email"] == username
         assert created_user["full_name"] == full_name
 
+        user_query = select(User).where(User.email == username)
+        user_db = db.exec(user_query).first()
+        assert user_db
+        assert user_db.email == username
+        assert user_db.full_name == full_name
+        assert verify_password(password, user_db.hashed_password)
+
 
 def test_register_user_forbidden_error(client: TestClient) -> None:
     with patch("app.core.config.settings.USERS_OPEN_REGISTRATION", False):
@@ -333,8 +356,15 @@ def test_update_user(
     )
     assert r.status_code == 200
     updated_user = r.json()
+
     assert updated_user["full_name"] == "Updated_full_name"
 
+    user_query = select(User).where(User.email == username)
+    user_db = db.exec(user_query).first()
+    db.refresh(user_db)
+    assert user_db
+    assert user_db.full_name == "Updated_full_name"
+
 
 def test_update_user_not_exists(
     client: TestClient, superuser_token_headers: dict[str, str]
@@ -388,6 +418,10 @@ def test_delete_user_super_user(
     deleted_user = r.json()
     assert deleted_user["message"] == "User deleted successfully"
 
+    user_query = select(User).where(User.id == user_id)
+    user_db = db.execute(user_query).first()
+    assert user_db is None
+
 
 def test_delete_user_current_user(client: TestClient, db: Session) -> None:
     username = random_email()
@@ -413,6 +447,10 @@ def test_delete_user_current_user(client: TestClient, db: Session) -> None:
     deleted_user = r.json()
     assert deleted_user["message"] == "User deleted successfully"
 
+    user_query = select(User).where(User.id == user_id)
+    user_db = db.execute(user_query).first()
+    assert user_db is None
+
 
 def test_delete_user_not_found(
     client: TestClient, superuser_token_headers: dict[str, str]