default html pages for 404 and 500

pydanny · pydanny · commit b62bd18eca2c · 2025-06-29T09:17:55.000+08:00
diff --git a/src/air/applications.py b/src/air/applications.py
@@ -22,11 +22,43 @@
 from typing_extensions import Annotated, Doc, deprecated
 from fastapi import FastAPI
 from .responses import TagResponse
+from .tags import Html, Head, Body, Main, H1, P, Title
 
 
 AppType = TypeVar("AppType", bound="FastAPI")
 
 
+async def default_404_exception_handler(request, exc):
+    return TagResponse(
+        Html(
+            Head(
+                Title("404 Not Found")),
+            Body(
+                Main(
+                    H1("404 Not Found"),
+                    P("The requested resource was not found on this server."),
+                )
+            ),
+        ),
+        status_code=404
+    )
+    
+
+async def default_500_exception_handler(request, exc):
+    return TagResponse(
+        Html(
+            Head(
+                Title("500 Internal Server Error")),
+            Body(
+                Main(
+                    H1("500 Internal Server Error"),
+                )
+            ),
+        ),
+        status_code=500
+    )    
+
+
 class Air(FastAPI):
     """FastAPI wrapper class with TagResponse as the default response class."""
 
@@ -301,7 +333,7 @@ async def read_items():
             # TODO: Have this accept default_response_class=default_response_class
             default_response_class=TagResponse,
             middleware=middleware,
-            exception_handlers=exception_handlers,
+            exception_handlers={404: default_404_exception_handler, 500: default_500_exception_handler},
             on_startup=on_startup,
             on_shutdown=on_shutdown,
             lifespan=lifespan,
diff --git a/tests/test_applications.py b/tests/test_applications.py
@@ -1,5 +1,6 @@
 from fastapi import FastAPI
 from fastapi.testclient import TestClient
+from fastapi.responses import HTMLResponse
 import air
 
 
@@ -46,3 +47,39 @@ def test_page():
     assert response.status_code == 200
     assert response.headers["content-type"] == "text/html; charset=utf-8"
     assert response.text == "<h1>Hello, World!</h1>"
+
+
+def test_air_404_response():
+    app = air.Air()
+
+    client = TestClient(app)
+    response = client.get("/nonexistent")
+
+    assert response.status_code == 404
+    assert response.headers["content-type"] == "text/html; charset=utf-8"
+    assert response.text == "<!doctype html><html><head><title>404 Not Found</title></head><body><main><h1>404 Not Found</h1><p>The requested resource was not found on this server.</p></main></body></html>"
+
+
+
+def test_air_500_response():
+
+    app = air.Air()
+
+    @app.get("/error")
+    def error_endpoint():
+        raise Exception("This is a test error")
+
+
+    client = TestClient(app)
+
+    try:
+        response = client.get("/error")
+    except:
+        
+
+
+
+    assert response.status_code == 500
+    assert response.headers["content-type"] == "text/html; charset=utf-8"
+    assert "Internal Server Error" in response.text
+    assert "This is a test error" in response.text
