fix: shopify shop validation

felipap · felipap · commit 7d86e35ef418 · 2024-11-23T23:04:19.000-05:00
diff --git a/handshake/src/providers/shopify.ts b/handshake/src/providers/shopify.ts
@@ -244,8 +244,8 @@ export const Shopify: HandlerFactory<Args, ShopifyAppCredential> = ({
       }
 
       // TODO validate shop value.
-      if (!extras.shop.match(/^[a-zA-Z][a-zA-Z_-]*\.myshopify.com$/)) {
-        throw Error("Invalid shop value.");
+      if (!extras.shop.match(/^[a-zA-Z][a-zA-Z_-0-9]*\.myshopify.com$/)) {
+        throw Error("Invalid extras.shop value.");
       }
 
       const authUrl = new URL(`https://${extras.shop}/admin/oauth/authorize`);

Original file line number	Diff line number	Diff line change
`@@ -244,8 +244,8 @@ export const Shopify: HandlerFactory<Args, ShopifyAppCredential> = ({`
`244`	`244`	`}`
`245`	`245`
`246`	`246`	`// TODO validate shop value.`
`247`		`- if (!extras.shop.match(/^[a-zA-Z][a-zA-Z_-]*\.myshopify.com$/)) {`
`248`		`- throw Error("Invalid shop value.");`
	`247`	`+ if (!extras.shop.match(/^[a-zA-Z][a-zA-Z_-0-9]*\.myshopify.com$/)) {`
	`248`	`+ throw Error("Invalid extras.shop value.");`
`249`	`249`	`}`
`250`	`250`
`251`	`251`	const authUrl = new URL(`https://${extras.shop}/admin/oauth/authorize`);