fix: artifact upload (#67)

Author: adamhenson

.github/workflows/extraHeaders.yml

@@ -8,6 +8,7 @@ jobs:
       ACTIONS_ALLOW_UNSECURE_COMMANDS: true
     steps:
       - uses: actions/checkout@master
+      - run: mkdir -p ${{ github.workspace }}/tmp/artifacts
       - uses: amondnet/now-deployment@master
         id: now
         with:
@@ -20,10 +21,10 @@ jobs:
         with:
           extraHeaders: '{ "x-test-1": "hello world", "x-test-2": "foo" }'
           fooApiToken: ${{ secrets.LIGHTHOUSE_CHECK_API_TOKEN }}
-          outputDirectory: /tmp/artifacts
+          outputDirectory: ${{ github.workspace }}/tmp/artifacts
           urlsJson: '[["cf8b27b3-ccb8-4477-83b6-ded2c375f977", "${{ steps.now.outputs.preview-url }}"]]'
       - name: Upload artifacts
         uses: actions/upload-artifact@master
         with:
           name: Lighthouse reports
-          path: /tmp/artifacts
+          path: ${{ github.workspace }}/tmp/artifacts

.github/workflows/test.yml

@@ -6,6 +6,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@master
+    - run: mkdir -p ${{ github.workspace }}/tmp/artifacts
     - name: Run Lighthouse
       uses: ./
       with:
@@ -18,12 +19,12 @@ jobs:
         gitBranch: ${{ github.ref }}
         gitHubAccessToken: ${{ secrets.LIGHTHOUSE_CHECK_GITHUB_ACCESS_TOKEN }}
         maxRetries: 1
-        outputDirectory: /tmp/artifacts
+        outputDirectory: ${{ github.workspace }}/tmp/artifacts
         urls: 'https://www.foo.software,https://www.foo.software/tag/articles/'
         sha: ${{ github.sha }}
         slackWebhookUrl: ${{ secrets.LIGHTHOUSE_CHECK_WEBHOOK_URL }}
     - name: Upload artifacts
       uses: actions/upload-artifact@master
       with:
         name: Lighthouse reports
-        path: /tmp/artifacts
+        path: ${{ github.workspace }}/tmp/artifacts

Dockerfile

@@ -5,7 +5,4 @@ COPY . .
 RUN npm install
 RUN npm run build
 
-# support a standard location for artifacts
-RUN mkdir -p /tmp/artifacts
-
 CMD [ "node", "/dist/index.js" ]

README.md

@@ -65,7 +65,7 @@ For detailed documentation of all inputs and advanced configuration - visit [the
     <td align="center" width="33.3333333333333%">
       <figure>
         <a href="https://lighthouse-check.s3.amazonaws.com/images/github-actions/github-action-lighthouse-check-lighthouse-report.png">
-          <img alt="Lighthouse Check GitHub action HTML report" src="https://lighthouse-check.s3.amazonaws.com/images/github-actions/github-action-lighthouse-check-lighthouse-report.png" />
+          <img alt="Lighthouse Check GitHub action HTML report" src="https://lighthouse-check.s3.amazonaws.com/images/github-actions/lighthouse-report.png" />
         </a>
         <figcaption>
           HTML Reports