Optimize metadata reset to clone repository once

Previously, reset_all_metadata_on_repository_in_tool_shed() cloned the
repository separately for each changeset revision over HTTP. With 6
changesets at ~6-7 seconds per clone, this took ~40 seconds total,
exceeding Playwright's 30-second timeout.

Now clone the repository once and use hg update to switch between
revisions. This reduces 6 network round-trips to 1, making the
operation complete well within the timeout.

Author: mvdbeek

lib/galaxy/tool_shed/metadata/metadata_generator.py

@@ -392,7 +392,9 @@ def generate_metadata_for_changeset_revision(self):
         if invalid_tool_configs:
             metadata_dict["invalid_tools"] = invalid_tool_configs
         self.metadata_dict = metadata_dict
-        remove_dir(work_dir)
+        # Only remove work_dir if not resetting all metadata - in that case the caller handles cleanup
+        if not self.resetting_all_metadata_on_repository:
+            remove_dir(work_dir)
 
     def generate_package_dependency_metadata(self, elem, valid_tool_dependencies_dict, invalid_tool_dependencies_dict):
         """

lib/tool_shed/metadata/repository_metadata_manager.py

@@ -799,14 +799,24 @@ def reset_all_metadata_on_repository_in_tool_shed(self, repository_clone_url=Non
         metadata_dict = None
         ancestor_changeset_revision = None
         ancestor_metadata_dict = None
-        for changeset in self.repository.get_changesets_for_setting_metadata(self.app):
-            work_dir = tempfile.mkdtemp(prefix="tmp-toolshed-ramorits")
-            ctx = repo[changeset]
-            log.debug("Cloning repository changeset revision: %s", str(ctx.rev()))
-            assert self.repository_clone_url
-            repository_clone_url = repository_clone_url or self.repository_clone_url
-            cloned_ok, error_message = hg_util.clone_repository(repository_clone_url, work_dir, str(ctx.rev()))
-            if cloned_ok:
+
+        # Clone repository once, then update for each changeset revision.
+        work_dir = tempfile.mkdtemp(prefix="tmp-toolshed-ramorits")
+        assert self.repository_clone_url
+        repository_clone_url = repository_clone_url or self.repository_clone_url
+        log.debug("Cloning repository for metadata reset")
+        cloned_ok, error_message = hg_util.clone_repository(repository_clone_url, work_dir)
+        if not cloned_ok:
+            log.error(f"Failed to clone repository: {error_message}")
+            basic_util.remove_dir(work_dir)
+            self._clean_repository_metadata(changeset_revisions)
+            return
+
+        try:
+            for changeset in self.repository.get_changesets_for_setting_metadata(self.app):
+                ctx = repo[changeset]
+                log.debug("Updating to changeset revision: %s", str(ctx.rev()))
+                hg_util.update_repository(work_dir, str(ctx.rev()))
                 log.debug("Generating metadata for changeset revision: %s", str(ctx.rev()))
                 self.set_changeset_revision(str(ctx))
                 self.set_repository_files_dir(work_dir)
@@ -823,11 +833,11 @@ def reset_all_metadata_on_repository_in_tool_shed(self, repository_clone_url=Non
                         # self.SUBSET - ancestor metadata is a subset of current metadata, so continue from current
                         # self.NOT_EQUAL_AND_NOT_SUBSET - ancestor metadata is neither equal to nor a subset of current
                         # metadata, so persist ancestor metadata.
-                        log.info(f"amd {ancestor_metadata_dict}")
+                        log.debug(f"amd {ancestor_metadata_dict}")
                         comparison = self.compare_changeset_revisions(
                             ancestor_changeset_revision, ancestor_metadata_dict
                         )
-                        log.info(f"comparison {comparison}")
+                        log.debug(f"comparison {comparison}")
                         if comparison in [self.NO_METADATA, self.EQUAL, self.SUBSET]:
                             ancestor_changeset_revision = self.changeset_revision
                             ancestor_metadata_dict = self.metadata_dict
@@ -858,6 +868,7 @@ def reset_all_metadata_on_repository_in_tool_shed(self, repository_clone_url=Non
                         changeset_revisions.append(metadata_changeset_revision)
                         ancestor_changeset_revision = None
                         ancestor_metadata_dict = None
+        finally:
             basic_util.remove_dir(work_dir)
         # Delete all repository_metadata records for this repository that do not have a changeset_revision
         # value in changeset_revisions.