From ddb08f0e8ed1bbcfe0cb56e0dba57b2fab28c90c Mon Sep 17 00:00:00 2001 From: guerler Date: Tue, 10 Feb 2026 18:26:33 +0300 Subject: [PATCH] Avoid slash duplication in display urls --- .../display_applications/parameters.py | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/lib/galaxy/datatypes/display_applications/parameters.py b/lib/galaxy/datatypes/display_applications/parameters.py index c5f2a4f74ee3..2eb9423a2a74 100644 --- a/lib/galaxy/datatypes/display_applications/parameters.py +++ b/lib/galaxy/datatypes/display_applications/parameters.py @@ -256,19 +256,17 @@ def url(self): base_url = self.trans.request.base if self.parameter.strip_https and base_url[:5].lower() == "https": base_url = f"http{base_url[5:]}" - return "{}{}".format( - base_url, - self.trans.app.url_for( - controller="dataset", - action="display_application", - dataset_id=self._dataset_hash, - user_id=self._user_hash, - app_name=quote_plus(self.parameter.link.display_application.id), - link_name=quote_plus(self.parameter.link.id), - app_action=self.action_name, - action_param=self._url, - ), + path = self.trans.app.url_for( + controller="dataset", + action="display_application", + dataset_id=self._dataset_hash, + user_id=self._user_hash, + app_name=quote_plus(self.parameter.link.display_application.id), + link_name=quote_plus(self.parameter.link.id), + app_action=self.action_name, + action_param=self._url, ) + return f"{base_url.rstrip('/')}/{path.lstrip('/')}" @property def action_name(self):