diff --git a/src/api/mod.rs b/src/api/mod.rs index 3888998d86..0cbaa3ad38 100644 --- a/src/api/mod.rs +++ b/src/api/mod.rs @@ -2054,8 +2054,6 @@ pub struct UpdatedRelease { pub projects: Option>, #[serde(skip_serializing_if = "Option::is_none")] pub url: Option, - #[serde(rename = "dateStarted", skip_serializing_if = "Option::is_none")] - pub date_started: Option>, #[serde(rename = "dateReleased", skip_serializing_if = "Option::is_none")] pub date_released: Option>, #[serde(skip_serializing_if = "Option::is_none")] diff --git a/src/commands/releases/finalize.rs b/src/commands/releases/finalize.rs index 1567cb6c3a..4e63d4b12d 100644 --- a/src/commands/releases/finalize.rs +++ b/src/commands/releases/finalize.rs @@ -20,9 +20,10 @@ pub fn make_command(command: Command) -> Command { .arg( Arg::new("started") .long("started") + .hide(true) .value_parser(get_timestamp) .value_name("TIMESTAMP") - .help("Set the release start date."), + .help("[DEPRECATED] This value is ignored."), ) .arg( Arg::new("released") @@ -38,13 +39,19 @@ pub fn execute(matches: &ArgMatches) -> Result<()> { let api = Api::current(); let version = matches.get_one::("version").unwrap(); + if matches.get_one::>("started").is_some() { + log::warn!( + "The --started flag is deprecated. Its value is ignored, \ + and the argument will be completely removed in a future version." + ); + } + api.authenticated()?.update_release( &config.get_org(matches)?, version, &UpdatedRelease { projects: config.get_projects(matches).ok(), url: matches.get_one::("url").cloned(), - date_started: matches.get_one::>("started").copied(), date_released: Some( matches .get_one::>("released") diff --git a/tests/integration/_cases/releases/releases-finalize-dates.trycmd b/tests/integration/_cases/releases/releases-finalize-dates.trycmd index 6a099239b7..e1d9ca2db9 100644 --- a/tests/integration/_cases/releases/releases-finalize-dates.trycmd +++ b/tests/integration/_cases/releases/releases-finalize-dates.trycmd @@ -1,5 +1,5 @@ ``` -$ sentry-cli releases finalize wat-release --started 1431648100 --released 1431648000 +$ sentry-cli releases finalize wat-release --released 1431648000 ? success Finalized release wat-release diff --git a/tests/integration/releases/finalize.rs b/tests/integration/releases/finalize.rs index 7d4759a3c7..b3b8e0246b 100644 --- a/tests/integration/releases/finalize.rs +++ b/tests/integration/releases/finalize.rs @@ -41,7 +41,6 @@ fn release_with_custom_dates() { .with_response_file("releases/get-release.json") .with_matcher(Matcher::PartialJson(json!({ "projects": ["wat-project"], - "dateStarted": "2015-05-15T00:01:40Z", "dateReleased": "2015-05-15T00:00:00Z" }))), )