Skip to content

Commit a465988

Browse files
committed
ggml : fix Q4_3 scalar imlpementation
1 parent c51e214 commit a465988

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

ggml.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3061,9 +3061,6 @@ static void ggml_vec_dot_q4_3_q8_0(const int n, float * restrict s, const void *
30613061
const float d1 = GGML_FP16_TO_FP32(x[2*i + 1].d);
30623062
const float m1 = GGML_FP16_TO_FP32(x[2*i + 1].m);
30633063

3064-
int sy_0 = 0;
3065-
int sy_1 = 0;
3066-
30673064
int sxy_0 = 0;
30683065
int sxy_1 = 0;
30693066

@@ -3083,15 +3080,11 @@ static void ggml_vec_dot_q4_3_q8_0(const int n, float * restrict s, const void *
30833080
const int y0_1 = y0[2*(j + QK8_0/4) + 0];
30843081
const int y1_1 = y0[2*(j + QK8_0/4) + 1];
30853082

3086-
sy_0 += y0_0 + y1_0;
3087-
sy_1 += y0_1 + y1_1;
3088-
30893083
sxy_0 += x0_0*y0_0 + x1_0*y1_0;
30903084
sxy_1 += x0_1*y0_1 + x1_1*y1_1;
30913085
}
30923086

3093-
sumf += (d0*sxy_0 + m0*sy_0)*y[i].d;
3094-
sumf += (d1*sxy_1 + m1*sy_1)*y[i].d;
3087+
sumf += (d0*sxy_0 + d1*sxy_1)*y[i].d + m0*y[i].s0 + m1*y[i].s1;
30953088
}
30963089
#endif
30973090

0 commit comments

Comments
 (0)