Don't hold a reference to the UnitHeader during DIE parsing (#839)

* Delete unit lifetime from `read::DebuggingInformationEntry`

* Delete unit lifetime from `read::EntriesRaw`

* Delete unit lifetime from `read::EntriesCursor`

* Delete unit lifetime from `read::EntriesTree`

Author: philipc

src/read/dwarf.rs

@@ -586,7 +586,7 @@ impl<R: Reader> Dwarf<R> {
     pub fn die_ranges(
         &self,
         unit: &Unit<R>,
-        entry: &DebuggingInformationEntry<'_, '_, R>,
+        entry: &DebuggingInformationEntry<'_, R>,
     ) -> Result<RangeIter<R>> {
         let mut low_pc = None;
         let mut high_pc = None;
@@ -1343,26 +1343,20 @@ impl<R: Reader> Unit<R> {
     }
 
     /// Read the `DebuggingInformationEntry` at the given offset.
-    pub fn entry(
-        &self,
-        offset: UnitOffset<R::Offset>,
-    ) -> Result<DebuggingInformationEntry<'_, '_, R>> {
+    pub fn entry(&self, offset: UnitOffset<R::Offset>) -> Result<DebuggingInformationEntry<'_, R>> {
         self.header.entry(&self.abbreviations, offset)
     }
 
     /// Navigate this unit's `DebuggingInformationEntry`s.
     #[inline]
-    pub fn entries(&self) -> EntriesCursor<'_, '_, R> {
+    pub fn entries(&self) -> EntriesCursor<'_, R> {
         self.header.entries(&self.abbreviations)
     }
 
     /// Navigate this unit's `DebuggingInformationEntry`s
     /// starting at the given offset.
     #[inline]
-    pub fn entries_at_offset(
-        &self,
-        offset: UnitOffset<R::Offset>,
-    ) -> Result<EntriesCursor<'_, '_, R>> {
+    pub fn entries_at_offset(&self, offset: UnitOffset<R::Offset>) -> Result<EntriesCursor<'_, R>> {
         self.header.entries_at_offset(&self.abbreviations, offset)
     }
 
@@ -1372,16 +1366,13 @@ impl<R: Reader> Unit<R> {
     pub fn entries_tree(
         &self,
         offset: Option<UnitOffset<R::Offset>>,
-    ) -> Result<EntriesTree<'_, '_, R>> {
+    ) -> Result<EntriesTree<'_, R>> {
         self.header.entries_tree(&self.abbreviations, offset)
     }
 
     /// Read the raw data that defines the Debugging Information Entries.
     #[inline]
-    pub fn entries_raw(
-        &self,
-        offset: Option<UnitOffset<R::Offset>>,
-    ) -> Result<EntriesRaw<'_, '_, R>> {
+    pub fn entries_raw(&self, offset: Option<UnitOffset<R::Offset>>) -> Result<EntriesRaw<'_, R>> {
         self.header.entries_raw(&self.abbreviations, offset)
     }
 
@@ -1545,7 +1536,7 @@ impl<'a, R: Reader> UnitRef<'a, R> {
     /// Return an iterator for the address ranges of a `DebuggingInformationEntry`.
     ///
     /// This uses `DW_AT_low_pc`, `DW_AT_high_pc` and `DW_AT_ranges`.
-    pub fn die_ranges(&self, entry: &DebuggingInformationEntry<'_, '_, R>) -> Result<RangeIter<R>> {
+    pub fn die_ranges(&self, entry: &DebuggingInformationEntry<'_, R>) -> Result<RangeIter<R>> {
         self.dwarf.die_ranges(self.unit, entry)
     }