Skip to content

Commit 9276955

Browse files
authored
write: Skip . and $ in section name for subsections when an empty name is given (#748)
So rather than producing .text. it now produces .text
1 parent 2b9db57 commit 9276955

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/write/coff/object.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,10 @@ impl<'a> Object<'a> {
7676

7777
pub(crate) fn coff_subsection_name(&self, section: &[u8], value: &[u8]) -> Vec<u8> {
7878
let mut name = section.to_vec();
79-
name.push(b'$');
80-
name.extend_from_slice(value);
79+
if !value.is_empty() {
80+
name.push(b'$');
81+
name.extend_from_slice(value);
82+
}
8183
name
8284
}
8385

src/write/elf/object.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,10 @@ impl<'a> Object<'a> {
113113

114114
pub(crate) fn elf_subsection_name(&self, section: &[u8], value: &[u8]) -> Vec<u8> {
115115
let mut name = section.to_vec();
116-
name.push(b'.');
117-
name.extend_from_slice(value);
116+
if !value.is_empty() {
117+
name.push(b'.');
118+
name.extend_from_slice(value);
119+
}
118120
name
119121
}
120122

0 commit comments

Comments
 (0)