refactor: refactor codebase for improved readability and context handling

- Add a new `.golangci.yml` configuration file with specified linters and formatters
- Rename `DB` parameter to `db` in `NewStoreWithDB` function in `redis.go`
- Add `context` package import in `tester.go` and `tester_options_samesite_go1.11.go`
- Replace `http.NewRequest` with `http.NewRequestWithContext` in multiple test functions in `tester.go` and `tester_options_samesite_go1.11.go`
- Refactor constants `sessionName` and `ok` into a single `const` block in `tester.go`

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

Author: appleboy

.golangci.yml

@@ -0,0 +1,50 @@
+version: "2"
+linters:
+  default: none
+  enable:
+    - bodyclose
+    - dogsled
+    - dupl
+    - errcheck
+    - exhaustive
+    - gochecknoinits
+    - goconst
+    - gocritic
+    - gocyclo
+    - goprintffuncname
+    - gosec
+    - govet
+    - ineffassign
+    - lll
+    - misspell
+    - nakedret
+    - noctx
+    - nolintlint
+    - rowserrcheck
+    - staticcheck
+    - unconvert
+    - unparam
+    - unused
+    - whitespace
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - gofumpt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

redis/redis.go

@@ -47,8 +47,8 @@ func NewStore(size int, network, address, username, password string, keyPairs ..
 // Returns:
 // - Store: The created session store.
 // - error: An error if the store could not be created.
-func NewStoreWithDB(size int, network, address, username, password, DB string, keyPairs ...[]byte) (Store, error) {
-	s, err := redistore.NewRediStoreWithDB(size, network, address, username, password, DB, keyPairs...)
+func NewStoreWithDB(size int, network, address, username, password, db string, keyPairs ...[]byte) (Store, error) {
+	s, err := redistore.NewRediStoreWithDB(size, network, address, username, password, db, keyPairs...)
 	if err != nil {
 		return nil, err
 	}

tester/tester.go

@@ -4,6 +4,7 @@
 package tester
 
 import (
+	"context"
 	"net/http"
 	"net/http/httptest"
 	"strings"
@@ -15,13 +16,10 @@ import (
 
 type storeFactory func(*testing.T) sessions.Store
 
-const sessionName = "mysession"
-
-const ok = "ok"
-
-func init() {
-	gin.SetMode(gin.TestMode)
-}
+const (
+	sessionName = "mysession"
+	ok          = "ok"
+)
 
 func GetSet(t *testing.T, newStore storeFactory) {
 	r := gin.Default()
@@ -44,11 +42,11 @@ func GetSet(t *testing.T, newStore storeFactory) {
 	})
 
 	res1 := httptest.NewRecorder()
-	req1, _ := http.NewRequest("GET", "/set", nil)
+	req1, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/set", nil)
 	r.ServeHTTP(res1, req1)
 
 	res2 := httptest.NewRecorder()
-	req2, _ := http.NewRequest("GET", "/get", nil)
+	req2, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/get", nil)
 	copyCookies(req2, res1)
 	r.ServeHTTP(res2, req2)
 }
@@ -81,16 +79,16 @@ func DeleteKey(t *testing.T, newStore storeFactory) {
 	})
 
 	res1 := httptest.NewRecorder()
-	req1, _ := http.NewRequest("GET", "/set", nil)
+	req1, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/set", nil)
 	r.ServeHTTP(res1, req1)
 
 	res2 := httptest.NewRecorder()
-	req2, _ := http.NewRequest("GET", "/delete", nil)
+	req2, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/delete", nil)
 	copyCookies(req2, res1)
 	r.ServeHTTP(res2, req2)
 
 	res3 := httptest.NewRecorder()
-	req3, _ := http.NewRequest("GET", "/get", nil)
+	req3, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/get", nil)
 	copyCookies(req3, res2)
 	r.ServeHTTP(res3, req3)
 }
@@ -128,16 +126,16 @@ func Flashes(t *testing.T, newStore storeFactory) {
 	})
 
 	res1 := httptest.NewRecorder()
-	req1, _ := http.NewRequest("GET", "/set", nil)
+	req1, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/set", nil)
 	r.ServeHTTP(res1, req1)
 
 	res2 := httptest.NewRecorder()
-	req2, _ := http.NewRequest("GET", "/flash", nil)
+	req2, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/flash", nil)
 	copyCookies(req2, res1)
 	r.ServeHTTP(res2, req2)
 
 	res3 := httptest.NewRecorder()
-	req3, _ := http.NewRequest("GET", "/check", nil)
+	req3, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/check", nil)
 	copyCookies(req3, res2)
 	r.ServeHTTP(res3, req3)
 }
@@ -173,11 +171,11 @@ func Clear(t *testing.T, newStore storeFactory) {
 	})
 
 	res1 := httptest.NewRecorder()
-	req1, _ := http.NewRequest("GET", "/set", nil)
+	req1, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/set", nil)
 	r.ServeHTTP(res1, req1)
 
 	res2 := httptest.NewRecorder()
-	req2, _ := http.NewRequest("GET", "/check", nil)
+	req2, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/check", nil)
 	copyCookies(req2, res1)
 	r.ServeHTTP(res2, req2)
 }
@@ -231,23 +229,23 @@ func Options(t *testing.T, newStore storeFactory) {
 	testOptionSameSitego(t, r)
 
 	res1 := httptest.NewRecorder()
-	req1, _ := http.NewRequest("GET", "/domain", nil)
+	req1, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/domain", nil)
 	r.ServeHTTP(res1, req1)
 
 	res2 := httptest.NewRecorder()
-	req2, _ := http.NewRequest("GET", "/path", nil)
+	req2, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/path", nil)
 	r.ServeHTTP(res2, req2)
 
 	res3 := httptest.NewRecorder()
-	req3, _ := http.NewRequest("GET", "/set", nil)
+	req3, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/set", nil)
 	r.ServeHTTP(res3, req3)
 
 	res4 := httptest.NewRecorder()
-	req4, _ := http.NewRequest("GET", "/expire", nil)
+	req4, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/expire", nil)
 	r.ServeHTTP(res4, req4)
 
 	res5 := httptest.NewRecorder()
-	req5, _ := http.NewRequest("GET", "/check", nil)
+	req5, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/check", nil)
 	r.ServeHTTP(res5, req5)
 
 	for _, c := range res1.Header().Values("Set-Cookie") {
@@ -298,11 +296,11 @@ func Many(t *testing.T, newStore storeFactory) {
 	})
 
 	res1 := httptest.NewRecorder()
-	req1, _ := http.NewRequest("GET", "/set", nil)
+	req1, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/set", nil)
 	r.ServeHTTP(res1, req1)
 
 	res2 := httptest.NewRecorder()
-	req2, _ := http.NewRequest("GET", "/get", nil)
+	req2, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/get", nil)
 	header := ""
 	for _, x := range res1.Header()["Set-Cookie"] {
 		header += strings.Split(x, ";")[0] + "; \n"

tester/tester_options_samesite_go1.11.go

@@ -4,6 +4,7 @@
 package tester
 
 import (
+	"context"
 	"net/http"
 	"net/http/httptest"
 	"strings"
@@ -25,7 +26,7 @@ func testOptionSameSitego(t *testing.T, r *gin.Engine) {
 	})
 
 	res3 := httptest.NewRecorder()
-	req3, _ := http.NewRequest("GET", "/sameSite", nil)
+	req3, _ := http.NewRequestWithContext(context.Background(), http.MethodGet, "/sameSite", nil)
 	r.ServeHTTP(res3, req3)
 
 	s := strings.Split(res3.Header().Get("Set-Cookie"), ";")