feat: add support to use placement group in launch template#4929
Merged
Conversation
edersonbrilhante
force-pushed
the
feat-placement
branch
2 times, most recently
from
c50f557 to
03c78ee
Compare
npalm
reviewed
Dec 6, 2025
edersonbrilhante
force-pushed
the
feat-placement
branch
from
bea36d0 to
9f79d06
Compare
npalm
approved these changes
Dec 8, 2025
npalm
requested changes
Dec 8, 2025
Member
npalm
left a comment
npalm
left a comment
There was a problem hiding this comment.
Sorry tiny change,
Can you add the group_id in both variables file with optional(null). And enable the line in the main.tf. The next branch is on provider 6.21
Contributor
Author
|
@npalm Updated :) |
npalm
added a commit
that referenced
this pull request
Dec 12, 2025
## Description This PR adds support for configuring EC2 placement groups for GitHub Actions runners in the multi-runner module. It plumbs a new placement option from the runner configuration through to the underlying EC2 runner module. ## Details Updated modules/multi-runner/runners.tf to pass placement = each.value.runner_config.placement into the runners module. This allows specifying AWS placement groups for EC2 runners, enabling tighter control over instance placement. The change is backwards compatible: if placement is unset in runner_config, behavior remains unchanged. ## Motivation / Future work Placement groups are a prerequisite for supporting macOS runners, which require a host_id. A follow-up PR will add explicit macOS support leveraging this new placement wiring. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
…ws-runners#4929) ## Description This PR adds support for configuring EC2 placement groups for GitHub Actions runners in the multi-runner module. It plumbs a new placement option from the runner configuration through to the underlying EC2 runner module. ## Details Updated modules/multi-runner/runners.tf to pass placement = each.value.runner_config.placement into the runners module. This allows specifying AWS placement groups for EC2 runners, enabling tighter control over instance placement. The change is backwards compatible: if placement is unset in runner_config, behavior remains unchanged. ## Motivation / Future work Placement groups are a prerequisite for supporting macOS runners, which require a host_id. A follow-up PR will add explicit macOS support leveraging this new placement wiring. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
…ing instead of a number (github-aws-runners#4979) # Description Fixes bug in github-aws-runners#4929 that assigned the type `number` to `host_resource_group_arn` instead of `string`. Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for configuring EC2 placement groups for GitHub Actions runners in the multi-runner module. It plumbs a new placement option from the runner configuration through to the underlying EC2 runner module.
Details
Updated modules/multi-runner/runners.tf to pass placement = each.value.runner_config.placement into the runners module.
This allows specifying AWS placement groups for EC2 runners, enabling tighter control over instance placement.
The change is backwards compatible: if placement is unset in runner_config, behavior remains unchanged.
Motivation / Future work
Placement groups are a prerequisite for supporting macOS runners, which require a host_id.
A follow-up PR will add explicit macOS support leveraging this new placement wiring.