Store in-flight child iseq in an array

This prevents them from being GC'd during compilation.  Then we nil out
the array later so it gets freed.

Author: tenderlove

compile.c

@@ -1226,7 +1226,7 @@ new_child_iseq(rb_iseq_t *iseq, const NODE *const node,
 				    rb_iseq_path(iseq), rb_iseq_realpath(iseq),
 				    INT2FIX(line_no), parent, type, ISEQ_COMPILE_DATA(iseq)->option);
     debugs("[new_child_iseq]< ---------------------------------------\n");
-    iseq_add_mark_object_compile_time(iseq, (VALUE)ret_iseq);
+    rb_ary_push(ISEQ_COMPILE_DATA(iseq)->child_iseq, (VALUE)ret_iseq);
     return ret_iseq;
 }
 
@@ -1241,7 +1241,7 @@ new_child_iseq_ifunc(rb_iseq_t *iseq, const struct vm_ifunc *ifunc,
 				 rb_iseq_path(iseq), rb_iseq_realpath(iseq),
 				 INT2FIX(line_no), parent, type, ISEQ_COMPILE_DATA(iseq)->option);
     debugs("[new_child_iseq_ifunc]< ---------------------------------------\n");
-    iseq_add_mark_object(iseq, (VALUE)ret_iseq);
+    rb_ary_push(ISEQ_COMPILE_DATA(iseq)->child_iseq, (VALUE)ret_iseq);
     return ret_iseq;
 }
 
@@ -2161,6 +2161,8 @@ iseq_set_sequence(rb_iseq_t *iseq, LINK_ANCHOR *const anchor)
     iseq->body->insns_info.positions = positions;
     iseq->body->insns_info.size = insns_info_index;
 
+    RB_OBJ_WRITE(iseq, &ISEQ_COMPILE_DATA(iseq)->child_iseq, 0); /* free */
+
     return COMPILE_OK;
 }
 

iseq.c

@@ -218,6 +218,7 @@ rb_iseq_mark(const rb_iseq_t *iseq)
     else if (ISEQ_COMPILE_DATA(iseq) != NULL) {
 	const struct iseq_compile_data *const compile_data = ISEQ_COMPILE_DATA(iseq);
 	RUBY_MARK_UNLESS_NULL(compile_data->mark_ary);
+	RUBY_MARK_UNLESS_NULL(compile_data->child_iseq);
 	RUBY_MARK_UNLESS_NULL(compile_data->err_info);
 	RUBY_MARK_UNLESS_NULL(compile_data->catch_table_ary);
     }
@@ -413,6 +414,7 @@ prepare_iseq_build(rb_iseq_t *iseq,
     ISEQ_COMPILE_DATA_ALLOC(iseq);
     RB_OBJ_WRITE(iseq, &ISEQ_COMPILE_DATA(iseq)->err_info, err_info);
     RB_OBJ_WRITE(iseq, &ISEQ_COMPILE_DATA(iseq)->mark_ary, rb_ary_tmp_new(3));
+    RB_OBJ_WRITE(iseq, &ISEQ_COMPILE_DATA(iseq)->child_iseq, rb_ary_tmp_new(3));
 
     ISEQ_COMPILE_DATA(iseq)->storage_head = ISEQ_COMPILE_DATA(iseq)->storage_current =
       (struct iseq_compile_data_storage *)

iseq.h

@@ -99,6 +99,7 @@ struct iseq_compile_data {
     /* GC is needed */
     const VALUE err_info;
     VALUE mark_ary;
+    VALUE child_iseq;
     const VALUE catch_table_ary;	/* Array */
 
     /* GC is not needed */