Skip to content

Commit d384d81

Browse files
authored
Merge pull request #736 from DrummyFloyd/oidc-fixes
fix(oidc): remove trailling / needed but add by User & Missing Oauth on /auth
2 parents 8e982f0 + cbc7d2b commit d384d81

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

apps/backend/src/services/auth/providers/oauth.provider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export class OauthProvider implements ProvidersInterface {
6060
}
6161

6262
async getToken(code: string): Promise<string> {
63-
const response = await fetch(`${this.tokenUrl}/`, {
63+
const response = await fetch(`${this.tokenUrl}`, {
6464
method: 'POST',
6565
headers: {
6666
'Content-Type': 'application/x-www-form-urlencoded',
@@ -85,7 +85,7 @@ export class OauthProvider implements ProvidersInterface {
8585
}
8686

8787
async getUser(access_token: string): Promise<{ email: string; id: string }> {
88-
const response = await fetch(`${this.userInfoUrl}/`, {
88+
const response = await fetch(`${this.userInfoUrl}`, {
8989
headers: {
9090
Authorization: `Bearer ${access_token}`,
9191
Accept: 'application/json',

apps/frontend/src/components/auth/register.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { LoadingComponent } from '@gitroom/frontend/components/layout/loading';
1414
import interClass from '@gitroom/react/helpers/inter.font';
1515
import clsx from 'clsx';
1616
import { GoogleProvider } from '@gitroom/frontend/components/auth/providers/google.provider';
17+
import { OauthProvider } from '@gitroom/frontend/components/auth/providers/oauth.provider';
1718
import { useFireEvents } from '@gitroom/helpers/utils/use.fire.events';
1819
import { useVariables } from '@gitroom/react/helpers/variable.context';
1920
import { useTrack } from '@gitroom/react/helpers/use.track';
@@ -91,7 +92,8 @@ export function RegisterAfter({
9192
token: string;
9293
provider: string;
9394
}) {
94-
const { isGeneral, neynarClientId, billingEnabled } = useVariables();
95+
const { isGeneral, genericOauth, neynarClientId, billingEnabled } =
96+
useVariables();
9597
const [loading, setLoading] = useState(false);
9698
const router = useRouter();
9799
const fireEvents = useFireEvents();
@@ -163,7 +165,11 @@ export function RegisterAfter({
163165
<GithubProvider />
164166
) : (
165167
<div className="gap-[5px] flex flex-col">
166-
<GoogleProvider />
168+
{genericOauth && isGeneral ? (
169+
<OauthProvider />
170+
) : (
171+
<GoogleProvider />
172+
)}
167173
{!!neynarClientId && <FarcasterProvider />}
168174
{billingEnabled && <WalletProvider />}
169175
</div>

0 commit comments

Comments
 (0)